Changeset 42065 in webkit for trunk/JavaScriptCore/runtime

Timestamp:

Mar 27, 2009, 8:50:39 PM (16 years ago)

Author:

[email protected]

Message:

Improve performance of Function.prototype.call
<​https://bugs.webkit.org/show_bug.cgi?id=24907>

Reviewed by Gavin Barraclough

Optimistically assume that expression.call(..) is going to be a call to
Function.prototype.call, and handle it specially to attempt to reduce the
degree of VM reentrancy.

When everything goes right this removes the vm reentry improving .call()
by around a factor of 10.

Location:

trunk/JavaScriptCore/runtime

Files:

• FunctionPrototype.cpp (modified) (1 diff)
• FunctionPrototype.h (modified) (1 diff)
• JSGlobalObject.cpp (modified) (2 diffs)
• JSGlobalObject.h (modified) (2 diffs)

trunk/JavaScriptCore/runtime/FunctionPrototype.cpp

@@ -44 +44 @@
 }
 
-void FunctionPrototype::addFunctionProperties(ExecState* exec, Structure* prototypeFunctionStructure)
+void FunctionPrototype::addFunctionProperties(ExecState* exec, Structure* prototypeFunctionStructure, PrototypeFunction** callFunction)
 {
     putDirectFunctionWithoutTransition(exec, new (exec) PrototypeFunction(exec, prototypeFunctionStructure, 0, exec->propertyNames().toString, functionProtoFuncToString), DontEnum);
     putDirectFunctionWithoutTransition(exec, new (exec) PrototypeFunction(exec, prototypeFunctionStructure, 2, exec->propertyNames().apply, functionProtoFuncApply), DontEnum);
-    putDirectFunctionWithoutTransition(exec, new (exec) PrototypeFunction(exec, prototypeFunctionStructure, 1, exec->propertyNames().call, functionProtoFuncCall), DontEnum);
+    *callFunction = new (exec) PrototypeFunction(exec, prototypeFunctionStructure, 1, exec->propertyNames().call, functionProtoFuncCall);
+    putDirectFunctionWithoutTransition(exec, *callFunction, DontEnum);
 }
 

trunk/JavaScriptCore/runtime/FunctionPrototype.h

@@ -26 +26 @@
 namespace JSC {
 
+    class PrototypeFunction;
+
     class FunctionPrototype : public InternalFunction {
     public:
         FunctionPrototype(ExecState*, PassRefPtr<Structure>);
-        void addFunctionProperties(ExecState*, Structure* prototypeFunctionStructure);
+        void addFunctionProperties(ExecState*, Structure* prototypeFunctionStructure, PrototypeFunction** callFunction);
 
         static PassRefPtr<Structure> createStructure(JSValuePtr proto)

trunk/JavaScriptCore/runtime/JSGlobalObject.cpp

@@ -204 +204 @@
     d()->functionPrototype = new (exec) FunctionPrototype(exec, FunctionPrototype::createStructure(jsNull())); // The real prototype will be set once ObjectPrototype is created.
     d()->prototypeFunctionStructure = PrototypeFunction::createStructure(d()->functionPrototype);
-    d()->functionPrototype->addFunctionProperties(exec, d()->prototypeFunctionStructure.get());
+    PrototypeFunction* callFunction = 0;
+    d()->functionPrototype->addFunctionProperties(exec, d()->prototypeFunctionStructure.get(), &callFunction);
+    d()->callFunction = callFunction;
     d()->objectPrototype = new (exec) ObjectPrototype(exec, ObjectPrototype::createStructure(jsNull()), d()->prototypeFunctionStructure.get());
     d()->functionPrototype->structure()->setPrototypeWithoutTransition(d()->objectPrototype);
@@ -371 +373 @@
 
     markIfNeeded(d()->evalFunction);
+    markIfNeeded(d()->callFunction);
 
     markIfNeeded(d()->objectPrototype);

trunk/JavaScriptCore/runtime/JSGlobalObject.h

@@ -41 +41 @@
     class NativeErrorConstructor;
     class ProgramCodeBlock;
+    class PrototypeFunction;
     class RegExpConstructor;
     class RegExpPrototype;
@@ -105 +106 @@
 
             GlobalEvalFunction* evalFunction;
+            PrototypeFunction* callFunction;
 
             ObjectPrototype* objectPrototype;