Changeset 42065 in webkit for trunk/JavaScriptCore/runtime/JSGlobalObject.cpp

Timestamp:

Mar 27, 2009, 8:50:39 PM (16 years ago)

Author:

[email protected]

Message:

Improve performance of Function.prototype.call
<​https://bugs.webkit.org/show_bug.cgi?id=24907>

Reviewed by Gavin Barraclough

Optimistically assume that expression.call(..) is going to be a call to
Function.prototype.call, and handle it specially to attempt to reduce the
degree of VM reentrancy.

When everything goes right this removes the vm reentry improving .call()
by around a factor of 10.

File:

• trunk/JavaScriptCore/runtime/JSGlobalObject.cpp (modified) (2 diffs)

trunk/JavaScriptCore/runtime/JSGlobalObject.cpp

@@ -204 +204 @@
     d()->functionPrototype = new (exec) FunctionPrototype(exec, FunctionPrototype::createStructure(jsNull())); // The real prototype will be set once ObjectPrototype is created.
     d()->prototypeFunctionStructure = PrototypeFunction::createStructure(d()->functionPrototype);
-    d()->functionPrototype->addFunctionProperties(exec, d()->prototypeFunctionStructure.get());
+    PrototypeFunction* callFunction = 0;
+    d()->functionPrototype->addFunctionProperties(exec, d()->prototypeFunctionStructure.get(), &callFunction);
+    d()->callFunction = callFunction;
     d()->objectPrototype = new (exec) ObjectPrototype(exec, ObjectPrototype::createStructure(jsNull()), d()->prototypeFunctionStructure.get());
     d()->functionPrototype->structure()->setPrototypeWithoutTransition(d()->objectPrototype);
@@ -371 +373 @@
 
     markIfNeeded(d()->evalFunction);
+    markIfNeeded(d()->callFunction);
 
     markIfNeeded(d()->objectPrototype);