Changeset 42606 in webkit for trunk/JavaScriptCore/runtime/Lookup.cpp

Timestamp:

Apr 16, 2009, 11:20:32 PM (16 years ago)

Author:

Stephanie Lewis

Message:

2009-04-16 Stephanie Lewis <Stephanie Lewis>

Reviewed by Oliver Hunt.

<rdar://problem/6744652> 32-bit to 64-bit: Javascript hash tables double in size

Remove perfect hash optimization which removes 1 MB of overhead on 32-bit and almost 2 MB on 64-bit. Removing the optimization was not a regression on SunSpider and the acid 3 test still passes.

• create_hash_table:
• runtime/Lookup.cpp: (JSC::HashTable::createTable): (JSC::HashTable::deleteTable):
• runtime/Lookup.h: (JSC::HashEntry::initialize): (JSC::HashEntry::next): (JSC::HashTable::entry):
• runtime/Structure.cpp: (JSC::Structure::getEnumerableNamesFromClassInfoTable):

File:

• trunk/JavaScriptCore/runtime/Lookup.cpp (modified) (3 diffs)

trunk/JavaScriptCore/runtime/Lookup.cpp

@@ -27 +27 @@
 void HashTable::createTable(JSGlobalData* globalData) const
 {
-#if ENABLE(PERFECT_HASH_SIZE)
-    ASSERT(!table);
-    HashEntry* entries = new HashEntry[hashSizeMask + 1];
-    for (int i = 0; i <= hashSizeMask; ++i)
-        entries[i].setKey(0);
-    for (int i = 0; values[i].key; ++i) {
-        UString::Rep* identifier = Identifier::add(globalData, values[i].key).releaseRef();
-        int hashIndex = identifier->computedHash() & hashSizeMask;
-        ASSERT(!entries[hashIndex].key());
-        entries[hashIndex].initialize(identifier, values[i].attributes, values[i].value1, values[i].value2);
-    }
-    table = entries;
-#else
     ASSERT(!table);
     int linkIndex = compactHashSizeMask + 1;
@@ -62 +49 @@
     }
     table = entries;
-#endif
 }
 
@@ -68 +54 @@
 {
     if (table) {
-#if ENABLE(PERFECT_HASH_SIZE)
-        int max = hashSizeMask + 1;
-#else
         int max = compactSize;
-#endif
         for (int i = 0; i != max; ++i) {
             if (UString::Rep* key = table[i].key())