Changeset 42680 in webkit for trunk/JavaScriptCore/API/JSBase.h

Timestamp:

Apr 20, 2009, 2:25:37 PM (16 years ago)

Author:

[email protected]

Message:

JavaScriptCore:

2009-04-20 Steve Falkenburg <​[email protected]>

Separate JavaScriptCore.dll from WebKit.dll.
Slight performance improvement or no change on benchmarks.

Allows us to break a circular dependency between CFNetwork and WebKit on Windows,
and simplifies standalone JavaScriptCore builds.

Reviewed by Oliver Hunt.

• API/JSBase.h: Export symbols with JS_EXPORT when using MSVC.
• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
• JavaScriptCore.vcproj/WTF/WTF.vcproj: Build JavaScriptCore as a DLL instead of a static library.
• config.h: Specify declspec(dllexport/dllimport) appropriately when exporting data.
• runtime/InternalFunction.h: Specify JS_EXPORTDATA on exported data.
• runtime/JSArray.h: Specify JS_EXPORTDATA on exported data.
• runtime/JSFunction.h: Specify JS_EXPORTDATA on exported data.
• runtime/StringObject.h: Specify JS_EXPORTDATA on exported data.
• runtime/UString.h: Specify JS_EXPORTDATA on exported data.

WebCore:

2009-04-20 Steve Falkenburg <​[email protected]>

Separate JavaScriptCore.dll from WebKit.dll.
Slight performance improvement or no change on benchmarks.

Allows us to break a circular dependency between CFNetwork and WebKit on Windows,
and simplifies standalone JavaScriptCore builds.

Reviewed by Oliver Hunt.

• config.h: Specify declspec(dllexport/dllimport) appropriately when exporting data.

WebKit/cf:

2009-04-20 Steve Falkenburg <​[email protected]>

Separate JavaScriptCore.dll from WebKit.dll.
Slight performance improvement or no change on benchmarks.

Allows us to break a circular dependency between CFNetwork and WebKit on Windows,
and simplifies standalone JavaScriptCore builds.

Reviewed by Oliver Hunt.

• WebCoreSupport/WebInspectorClientCF.cpp: Workaround for lack of config.h in shared WebKit file (WebKit/win uses config.h from WebCore).

WebKit/win:

2009-04-20 Steve Falkenburg <​[email protected]>

Separate JavaScriptCore.dll from WebKit.dll.
Slight performance improvement or no change on benchmarks.

Allows us to break a circular dependency between CFNetwork and WebKit on Windows,
and simplifies standalone JavaScriptCore builds.

Reviewed by Oliver Hunt.

• WebKit.vcproj/WebKit.def: Mark JavaScriptCore re-exports as deprecated.
• WebKit.vcproj/WebKit.vcproj: Link against JavaScriptCore.dll
• WebKit.vcproj/WebKit_debug.def: Mark JavaScriptCore re-exports as deprecated.

WebKitLibraries:

2009-04-20 Steve Falkenburg <​[email protected]>

Separate JavaScriptCore.dll from WebKit.dll.
Slight performance improvement or no change on benchmarks.

Allows us to break a circular dependency between CFNetwork and WebKit on Windows,
and simplifies standalone JavaScriptCore builds.

Reviewed by Oliver Hunt.

• win/tools/vsprops/common.vsprops: Add BUILDING_{project} preprocessor define.

WebKitTools:

2009-04-20 Steve Falkenburg <​[email protected]>

Separate JavaScriptCore.dll from WebKit.dll.
Slight performance improvement or no change on benchmarks.

Allows us to break a circular dependency between CFNetwork and WebKit on Windows,
and simplifies standalone JavaScriptCore builds.

Reviewed by Oliver Hunt.

• DumpRenderTree/config.h: Specify JS, WebKit exported data as declspec(dllimport)
• DumpRenderTree/win/DumpRenderTree.vcproj: Link against JavaScriptCore.dll

File:

• trunk/JavaScriptCore/API/JSBase.h (modified) (1 diff)

trunk/JavaScriptCore/API/JSBase.h

@@ -73 +73 @@
      * See http://bugs.webkit.org/show_bug.cgi?id=16227
      */
-    #define JS_EXPORT
+    #if defined(BUILDING_JavaScriptCore) || defined(BUILDING_WTF)
+    #define JS_EXPORT __declspec(dllexport)
+    #else
+    #define JS_EXPORT __declspec(dllimport)
+    #endif
 #else
     #define JS_EXPORT