Changeset 42922 in webkit for trunk/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp

Timestamp:

Apr 28, 2009, 12:10:34 AM (16 years ago)

Author:

[email protected]

Message:

2009-04-27 Gavin Barraclough <​[email protected]>

Reviewed by Maciej Stachowiak.

Tweak a loop condition to keep GCC happy,
some GCCs seem to be having issues with this. :-/

• bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::breakTarget):
• wtf/Platform.h:

File:

• trunk/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp (modified) (1 diff)

trunk/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp

@@ -1588 +1588 @@
 {
     // Reclaim free label scopes.
-    while (m_labelScopes.size() && !m_labelScopes.last().refCount())
+    //
+    // The condition was previously coded as 'm_labelScopes.size() && !m_labelScopes.last().refCount()',
+    // however sometimes this appears to lead to GCC going a little haywire and entering the loop with
+    // size 0, leading to segfaulty badness.  We are yet to identify a valid cause within our code to
+    // cause the GCC codegen to misbehave in this fashion, and as such the following refactoring of the
+    // loop condition is a workaround.
+    while (m_labelScopes.size()) {
+        if  (m_labelScopes.last().refCount())
+            break;
         m_labelScopes.removeLast();
+    }
 
     if (!m_labelScopes.size())