Changeset 43153 in webkit for trunk/JavaScriptCore/runtime/JSImmediate.h

Timestamp:

May 2, 2009, 6:58:45 PM (16 years ago)

Author:

[email protected]

Message:

JavaScriptCore:

2009-05-02 Geoffrey Garen <​[email protected]>

Reviewed by Sam Weinig.

Simplified null-ish JSValues.

Replaced calls to noValue() with calls to JSValue() (which is what
noValue() returned). Removed noValue().

Replaced almost all uses of jsImpossibleValue() with uses of JSValue().
Its one remaining use is for construction of hash table deleted values.
For that specific task, I made a new, private constructor with a special
tag. Removed jsImpossibleValue().

Removed "JSValue()" initialiazers, since default construction happens...
by default.

• API/JSCallbackObjectFunctions.h: (JSC::::call):
• bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitLoad):
• bytecompiler/BytecodeGenerator.h:
• debugger/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::evaluate):
• debugger/DebuggerCallFrame.h: (JSC::DebuggerCallFrame::DebuggerCallFrame):
• interpreter/CallFrame.h: (JSC::ExecState::clearException):
• interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute): (JSC::Interpreter::retrieveLastCaller):
• interpreter/Register.h: (JSC::Register::Register):
• jit/JITCall.cpp: (JSC::JIT::unlinkCall): (JSC::JIT::compileOpCallInitializeCallFrame): (JSC::JIT::compileOpCall):
• jit/JITStubs.cpp: (JSC::JITStubs::cti_op_call_eval): (JSC::JITStubs::cti_vm_throw):
• profiler/Profiler.cpp: (JSC::Profiler::willExecute): (JSC::Profiler::didExecute):
• runtime/ArrayPrototype.cpp: (JSC::getProperty):
• runtime/Completion.cpp: (JSC::evaluate):
• runtime/Completion.h: (JSC::Completion::Completion):
• runtime/GetterSetter.cpp: (JSC::GetterSetter::getPrimitiveNumber):
• runtime/JSArray.cpp: (JSC::JSArray::putSlowCase): (JSC::JSArray::deleteProperty): (JSC::JSArray::increaseVectorLength): (JSC::JSArray::setLength): (JSC::JSArray::pop): (JSC::JSArray::sort): (JSC::JSArray::compactForSorting):
• runtime/JSCell.cpp: (JSC::JSCell::getJSNumber):
• runtime/JSCell.h: (JSC::JSValue::getJSNumber):
• runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
• runtime/JSImmediate.h: (JSC::JSImmediate::fromNumberOutsideIntegerRange): (JSC::JSImmediate::from):
• runtime/JSNumberCell.cpp: (JSC::jsNumberCell):
• runtime/JSObject.cpp: (JSC::callDefaultValueFunction):
• runtime/JSObject.h: (JSC::JSObject::getDirect):
• runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::toPrimitive):
• runtime/JSPropertyNameIterator.h: (JSC::JSPropertyNameIterator::next):
• runtime/JSValue.h: (JSC::JSValue::): (JSC::JSValueHashTraits::constructDeletedValue): (JSC::JSValueHashTraits::isDeletedValue): (JSC::JSValue::JSValue):
• runtime/JSWrapperObject.h: (JSC::JSWrapperObject::JSWrapperObject):
• runtime/Operations.h: (JSC::resolveBase):
• runtime/PropertySlot.h: (JSC::PropertySlot::clearBase): (JSC::PropertySlot::clearValue):

WebCore:

2009-05-02 Geoffrey Garen <​[email protected]>

Reviewed by Sam Weinig.

Simplified null-ish JSValues.

Replaced calls to noValue() with calls to JSValue() (which is what
noValue() returned). Removed noValue().

Removed "JSValue()" initialiazers, since default construction happens...
by default.

• bindings/js/JSDOMBinding.cpp: (WebCore::setDOMException):
• bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::open): (WebCore::JSDOMWindow::showModalDialog):
• bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::handleEvent):
• bindings/js/JSJavaScriptCallFrameCustom.cpp: (WebCore::JSJavaScriptCallFrame::evaluate):
• bindings/js/JSSQLResultSetRowListCustom.cpp: (WebCore::JSSQLResultSetRowList::item):
• bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluate):
• bindings/js/ScriptValue.h: (WebCore::ScriptValue::ScriptValue): (WebCore::ScriptValue::hasNoValue):
• bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate):
• bridge/jni/jni_instance.cpp: (JavaInstance::invokeMethod):
• bridge/jni/jni_runtime.cpp: (JavaField::dispatchValueFromInstance): (JavaField::dispatchSetValueToInstance):
• bridge/runtime.h: (JSC::Bindings::Instance::invokeConstruct):

WebKit/mac:

2009-05-02 Geoffrey Garen <​[email protected]>

Reviewed by Sam Weinig.

Simplified null-ish JSValues.

Replaced calls to noValue() with calls to JSValue() (which is what
noValue() returned). Removed noValue().

Removed "JSValue()" initialiazers, since default construction happens...
by default.

• WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame evaluateWebScript:]):

File:

• trunk/JavaScriptCore/runtime/JSImmediate.h (modified) (5 diffs)

trunk/JavaScriptCore/runtime/JSImmediate.h

@@ -284 +284 @@
         static JSValue oneImmediate();
 
-        static JSValue impossibleValue();
-        
         static JSObject* prototype(JSValue, ExecState*);
 
@@ -377 +375 @@
     ALWAYS_INLINE JSValue JSImmediate::oneImmediate() { return makeInt(1); }
 
-    // This value is impossible because 0x4 is not a valid pointer but a tag of 0 would indicate non-immediate
-    ALWAYS_INLINE JSValue JSImmediate::impossibleValue() { return makeValue(0x4); }
-
 #if USE(ALTERNATE_JSIMMEDIATE)
     inline bool doubleToBoolean(double value)
@@ -417 +412 @@
     inline JSValue JSImmediate::fromNumberOutsideIntegerRange(T)
     {
-        return noValue();
+        return JSValue();
     }
 #endif
@@ -479 +474 @@
     {
         if ((i < minImmediateInt) | (i > maxImmediateInt))
-            return noValue();
+            return JSValue();
         return makeInt(static_cast<intptr_t>(i));
     }
@@ -553 +548 @@
     uint32_t toUInt32SlowCase(double, bool& ok);
 
-    inline JSValue::JSValue(ImpossibleValueTag)
-    {
-        *this = JSImmediate::impossibleValue();
-    }
-
     inline JSValue::JSValue(JSNullTag)
     {