Changeset 43375 in webkit for trunk/JavaScriptCore/runtime/JSGlobalData.cpp

Timestamp:

May 7, 2009, 4:51:12 PM (16 years ago)

Author:

[email protected]

Message:

2009-05-07 Geoffrey Garen <​[email protected]>

Reviewed by Cameron Zwarich.

Fixed a minor sequencing error introduced by recent Parser speedups.

• parser/Parser.cpp: (JSC::Parser::parse):
• parser/Parser.h: (JSC::Parser::parse): (JSC::Parser::reparse): Shrink the parsedObjects vector after allocating the root node, to avoid leaving a stray node in the vector, since that's a slight memory leak, and it causes problems during JSGlobalData teardown.

• runtime/JSGlobalData.cpp: (JSC::JSGlobalData::~JSGlobalData): ASSERT that we're not being torn down while we think we're still parsing, since that would cause lots of bad memory references during our destruction.

File:

• trunk/JavaScriptCore/runtime/JSGlobalData.cpp (modified) (1 diff)

trunk/JavaScriptCore/runtime/JSGlobalData.cpp

@@ -184 +184 @@
 
     delete clientData;
+    
+    ASSERT(parserObjects.isEmpty());
 }