Changeset 43551 in webkit for trunk/JavaScriptCore/runtime/JSObject.cpp

Timestamp:

May 11, 2009, 10:31:02 PM (16 years ago)

Author:

[email protected]

Message:

JavaScriptCore:

2009-05-11 Gavin Barraclough <​[email protected]>

Reviewed by Cameron Zwarich.

Implement JIT generation for instanceof for non-objects (always returns false).
Also fixes the sequencing of the prototype and value isObject checks, to no match the spec.

0.5% progression on v8 tests overall, due to 3.5% on early-boyer.

• jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
• runtime/JSObject.cpp: (JSC::JSObject::hasInstance):
• runtime/TypeInfo.h: (JSC::TypeInfo::TypeInfo):

LayoutTests:

2009-05-11 Gavin Barraclough <​[email protected]>

Reviewed by Oliver Hunt.

Add a layout test for instanceof.

• fast/js/instance-of-immediates-expected.txt: Added.
• fast/js/instance-of-immediates.html: Added.
• fast/js/resources/instance-of-immediates.js: Added. (testInstanceOf): (): (testSet):

File:

• trunk/JavaScriptCore/runtime/JSObject.cpp (modified) (1 diff)

trunk/JavaScriptCore/runtime/JSObject.cpp

@@ -388 +388 @@
 bool JSObject::hasInstance(ExecState* exec, JSValue value, JSValue proto)
 {
+    if (!value.isObject())
+        return false;
+
     if (!proto.isObject()) {
         throwError(exec, TypeError, "instanceof called on an object with an invalid prototype property.");
         return false;
     }
-
-    if (!value.isObject())
-        return false;
 
     JSObject* object = asObject(value);