Changeset 43603 in webkit for trunk/JavaScriptCore/runtime/JSActivation.cpp

Timestamp:

May 12, 2009, 7:39:34 PM (16 years ago)

Author:

[email protected]

Message:

<rdar://problem/6879881> Crash occurs at JSC::JSActivation::mark() when loading ​http://www.monster.com; ​http://www.cnet.com
<​https://bugs.webkit.org/show_bug.cgi?id=25736> Crash loading www.google.dk/ig (and other igoogle's as well)

Reviewed by Gavin Barraclough.

Following on from the lazy arguments creation patch, it's now
possible for an activation to to have a null register in the callframe
so we can't just blindly mark the local registers in an activation,
and must null check first instead.

File:

• trunk/JavaScriptCore/runtime/JSActivation.cpp (modified) (1 diff)

trunk/JavaScriptCore/runtime/JSActivation.cpp

@@ -76 +76 @@
     for ( ; i < count; ++i) {
         Register& r = registerArray[i];
-        if (!r.marked())
+        if (r.jsValue() && !r.marked())
             r.mark();
     }