Changeset 4363 in webkit for trunk/JavaScriptCore/kjs/internal.cpp

Timestamp:

May 13, 2003, 2:19:57 PM (22 years ago)

Author:

mjs

Message:

JavaScriptCore:

Reviewed by Darin.

• fixed 3254484 - Add a way to print JavaScript exceptions to the console via the debug menu
• improved JavaScript error message format

• kjs/error_object.cpp: (ErrorProtoFuncImp::call): Include line number in toString output.
• kjs/internal.cpp: (Parser::parse): Remove redundant fprintf.
• kjs/interpreter.cpp: (Interpreter::evaluate): Log if the flag is on. Include filename in log output. (Interpreter::shouldPrintExceptions): Check the global flag. (Interpreter::setShouldPrintExceptions): Set the global flag.
• kjs/interpreter.h:
• kjs/nodes.cpp: (Node::throwError): Add variants that include value and expression or label in format. (NewExprNode::evaluate): Improve error message. (FunctionCallNode::evaluate): Improve error message. (RelationalNode::evaluate): Improve error message. (ContinueNode::execute): Improve error message. (BreakNode::execute): Improve error message. (LabelNode::execute): Improve error message.
• kjs/nodes.h:

WebCore:

Reviewed by Darin.

• fixed 3254484 - Add a way to print JavaScript exceptions to the console via the debug menu

• khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::evaluate): Pass the filename.
• kwq/WebCoreJavaScript.h:
• kwq/WebCoreJavaScript.mm: (+[WebCoreJavaScript shouldPrintExceptions]): Call through to JavaScriptCore. (+[WebCoreJavaScript setShouldPrintExceptions:]): Call through to JavaScriptCore.
• khtml/ecma/kjs_events.cpp: (JSEventListener::handleEvent): Print exception if there is one.
• khtml/ecma/kjs_window.cpp: (ScheduledAction::execute): Print exception in the function case.

WebKit:

Reviewed by Darin.

• fixed 3254484 - Add a way to print JavaScript exceptions to the console via the debug menu

• Misc.subproj/WebCoreStatistics.h:
• Misc.subproj/WebCoreStatistics.m: (+[WebCoreStatistics shouldPrintExceptions]): Call through to WebCore. (+[WebCoreStatistics setShouldPrintExceptions:]): Call through to WebCore.

WebBrowser:

Reviewed by Darin.

• fixed 3254484 - Add a way to print JavaScript exceptions to the console via the debug menu

• Debug/DebugUtilities.m: (-[DebugUtilities createDebugMenu]): Include "Log JavaScript Exceptions" item. (-[BrowserDocument toggleLogJavaScriptExceptions:]): Call WebKit to do the toggle. (-[BrowserDocument validate_toggleLogJavaScriptExceptions:]): Set state properly.

File:

• trunk/JavaScriptCore/kjs/internal.cpp (modified) (1 diff)

trunk/JavaScriptCore/kjs/internal.cpp

@@ -456 +456 @@
     if (errMsg)
       *errMsg = "Parse error at line " + UString::from(eline);
-#ifndef NDEBUG
-    fprintf(stderr, "KJS: JavaScript parse error at line %d.\n", eline);
-#endif
     delete prog;
     return 0;