Changeset 43661 in webkit for trunk/JavaScriptCore/parser/ParserArena.h

Timestamp:

May 13, 2009, 2:53:59 PM (16 years ago)

Author:

Darin Adler

Message:

JavaScriptCore:

2009-05-13 Darin Adler <Darin Adler>

Revert the parser arena change. It was a slowdown, not a speedup.
Better luck next time (I'll break it up into pieces).

WebCore:

2009-05-13 Darin Adler <Darin Adler>

Revert the parser arena change. It was a slowdown, not a speedup.
Better luck next time (I'll break it up into pieces).

WebKit/mac:

2009-05-13 Darin Adler <Darin Adler>

Revert the parser arena change. It was a slowdown, not a speedup.
Better luck next time (I'll break it up into pieces).

File:

• trunk/JavaScriptCore/parser/ParserArena.h (modified) (2 diffs)

trunk/JavaScriptCore/parser/ParserArena.h

@@ -27 +27 @@
 #define ParserArena_h
 
-#include "Identifier.h"
-#include "SegmentedVector.h"
+#include <wtf/PassRefPtr.h>
+#include <wtf/RefPtr.h>
+#include <wtf/Vector.h>
 
 namespace JSC {
@@ -35 +36 @@
     class ParserArenaRefCounted;
 
-    typedef SegmentedVector<Identifier, 64> IdentifierArena;
-
-    class ParserArena : Noncopyable {
+    class ParserArena {
     public:
-        ParserArena();
-        ~ParserArena();
-
         void swap(ParserArena& otherArena)
         {
-            std::swap(m_freeableMemory, otherArena.m_freeableMemory);
-            std::swap(m_freeablePoolEnd, otherArena.m_freeablePoolEnd);
-            m_identifierArena.swap(otherArena.m_identifierArena);
-            m_freeablePools.swap(otherArena.m_freeablePools);
             m_deletableObjects.swap(otherArena.m_deletableObjects);
             m_refCountedObjects.swap(otherArena.m_refCountedObjects);
         }
+        ~ParserArena();
 
-        void* allocateFreeable(size_t size)
-        {
-            ASSERT(size);
-            ASSERT(size <= freeablePoolSize);
-            size_t alignedSize = alignSize(size);
-            ASSERT(alignedSize <= freeablePoolSize);
-            if (UNLIKELY(static_cast<size_t>(m_freeablePoolEnd - m_freeableMemory) < alignedSize))
-                allocateFreeablePool();
-            void* block = m_freeableMemory;
-            m_freeableMemory += alignedSize;
-            return block;
-        }
+        void deleteWithArena(ParserArenaDeletable* object) { m_deletableObjects.append(object); }
+        void derefWithArena(PassRefPtr<ParserArenaRefCounted> object) { m_refCountedObjects.append(object); }
 
-        void* allocateDeletable(size_t size)
-        {
-            ParserArenaDeletable* deletable = static_cast<ParserArenaDeletable*>(fastMalloc(size));
-            m_deletableObjects.append(deletable);
-            return deletable;
-        }
-
-        void derefWithArena(PassRefPtr<ParserArenaRefCounted> object) { m_refCountedObjects.append(object); }
         bool contains(ParserArenaRefCounted*) const;
         ParserArenaRefCounted* last() const;
         void removeLast();
 
-        bool isEmpty() const;
+        bool isEmpty() const { return m_deletableObjects.isEmpty() && m_refCountedObjects.isEmpty(); }
         void reset();
 
-        const Identifier& makeIdentifier(JSGlobalData*, const UChar* character, size_t length);
-        const Identifier& makeNumericIdentifier(JSGlobalData*, double number);
-
-        IdentifierArena& identifierArena() { return *m_identifierArena; }
-
     private:
-        static const size_t freeablePoolSize = 8000;
-
-        static size_t alignSize(size_t size)
-        {
-            return (size + sizeof(WTF::AllocAlignmentInteger) - 1) & ~(sizeof(WTF::AllocAlignmentInteger) - 1);
-        }
-
-        void* freeablePool();
-        void allocateFreeablePool();
-        void deallocateObjects();
-
-        char* m_freeableMemory;
-        char* m_freeablePoolEnd;
-
-        OwnPtr<IdentifierArena> m_identifierArena;
-        Vector<void*> m_freeablePools;
         Vector<ParserArenaDeletable*> m_deletableObjects;
         Vector<RefPtr<ParserArenaRefCounted> > m_refCountedObjects;
     };
 
-    ALWAYS_INLINE const Identifier& makeIdentifier(IdentifierArena& arena, JSGlobalData* globalData, const UChar* characters, size_t length)
-    {
-        arena.append(Identifier(globalData, characters, length));
-        return arena.last();
-    }
-
-    ALWAYS_INLINE const Identifier& ParserArena::makeIdentifier(JSGlobalData* globalData, const UChar* characters, size_t length)
-    {
-        return JSC::makeIdentifier(*m_identifierArena, globalData, characters, length);
-    }
-
 }