Changeset 44476 in webkit for trunk/JavaScriptCore/jit/JIT.h

Timestamp:

Jun 5, 2009, 5:08:00 PM (16 years ago)

Author:

[email protected]

Message:

2009-06-05 Gavin Barraclough <​[email protected]>

Reviewed by Sam Weinig.

Remove patchLength..tByIdExternalLoadPrefix magic numbers from JIT.h.

These aren't really suitable values to be tracking within common code
of the JIT, since they are not (and realistically cannot) be checked
by ASSERTs, as the other repatch offsets are. Move this functionality
(skipping the REX prefix when patching load instructions to LEAs on
x86-64) into the X86Assembler.

• assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::CodeLocationInstruction::repatchLoadPtrToLEA):
• assembler/X86Assembler.h: (JSC::X86Assembler::repatchLoadPtrToLEA):
• jit/JIT.h:
• jit/JITPropertyAccess.cpp: (JSC::JIT::patchGetByIdSelf): (JSC::JIT::patchPutByIdReplace):

File:

• trunk/JavaScriptCore/jit/JIT.h (modified) (4 diffs)

trunk/JavaScriptCore/jit/JIT.h

@@ -243 +243 @@
         static const int patchOffsetPutByIdExternalLoad = 20;
         static const int patchLengthPutByIdExternalLoad = 4;
-        static const int patchLengthPutByIdExternalLoadPrefix = 1;
         static const int patchOffsetPutByIdPropertyMapOffset = 31;
         // These architecture specific value are used to enable patching - see comment on op_get_by_id.
@@ -250 +249 @@
         static const int patchOffsetGetByIdExternalLoad = 20;
         static const int patchLengthGetByIdExternalLoad = 4;
-        static const int patchLengthGetByIdExternalLoadPrefix = 1;
         static const int patchOffsetGetByIdPropertyMapOffset = 31;
         static const int patchOffsetGetByIdPutResult = 31;
@@ -268 +266 @@
         static const int patchOffsetPutByIdExternalLoad = 13;
         static const int patchLengthPutByIdExternalLoad = 3;
-        static const int patchLengthPutByIdExternalLoadPrefix = 0;
         static const int patchOffsetPutByIdPropertyMapOffset = 22;
         // These architecture specific value are used to enable patching - see comment on op_get_by_id.
@@ -275 +272 @@
         static const int patchOffsetGetByIdExternalLoad = 13;
         static const int patchLengthGetByIdExternalLoad = 3;
-        static const int patchLengthGetByIdExternalLoadPrefix = 0;
         static const int patchOffsetGetByIdPropertyMapOffset = 22;
         static const int patchOffsetGetByIdPutResult = 22;