Changeset 44525 in webkit for trunk/JavaScriptCore/jit/JITPropertyAccess.cpp

Timestamp:

Jun 9, 2009, 12:46:31 AM (16 years ago)

Author:

[email protected]

Message:

2009-06-09 Gavin Barraclough <​[email protected]>

Reviewed by Mark Rowe & Geoff Garen.

Enable JIT_OPTIMIZE_PROPERTY_ACCESS on ARMv7 platforms.

Firm up interface for planting load intructions that will be repatched by
repatchLoadPtrToLEA(). This method should now no longer be applied to just
any loadPtr instruction.

• assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::loadPtrWithPatchToLEA):

Implement loadPtrWithPatchToLEA interface (plants a load with a fixed width address).

(JSC::MacroAssemblerARMv7::move):
(JSC::MacroAssemblerARMv7::nearCall):
(JSC::MacroAssemblerARMv7::call):
(JSC::MacroAssemblerARMv7::moveWithPatch):
(JSC::MacroAssemblerARMv7::tailRecursiveCall):

Switch to use common method 'moveFixedWidthEncoding()' to perform fixed width (often patchable) loads.

(JSC::MacroAssemblerARMv7::moveFixedWidthEncoding):

Move an immediate to a register, always plants movT3/movt instruction pair.

• assembler/MacroAssemblerX86.h: (JSC::MacroAssemblerX86::loadPtrWithPatchToLEA):

Implement loadPtrWithPatchToLEA interface (just a regular 32-bit load on x86).

• assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::loadPtrWithPatchToLEA):

Implement loadPtrWithPatchToLEA interface (just a regular 64-bit load on x86_64).

• jit/JITPropertyAccess.cpp: (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::emit_op_put_by_id):
• wtf/Platform.h:

Change to enable JIT_OPTIMIZE_PROPERTY_ACCESS.

File:

• trunk/JavaScriptCore/jit/JITPropertyAccess.cpp (modified) (2 diffs)

trunk/JavaScriptCore/jit/JITPropertyAccess.cpp

@@ -291 +291 @@
     ASSERT(differenceBetween(hotPathBegin, structureCheck) == patchOffsetGetByIdBranchToSlowCase);
 
-    Label externalLoad(this);
-    loadPtr(Address(regT0, FIELD_OFFSET(JSObject, m_externalStorage)), regT0);
+    Label externalLoad = loadPtrWithPatchToLEA(Address(regT0, FIELD_OFFSET(JSObject, m_externalStorage)), regT0);
     Label externalLoadComplete(this);
     ASSERT(differenceBetween(hotPathBegin, externalLoad) == patchOffsetGetByIdExternalLoad);
@@ -363 +362 @@
 
     // Plant a load from a bogus ofset in the object's property map; we will patch this later, if it is to be used.
-    Label externalLoad(this);
-    loadPtr(Address(regT0, FIELD_OFFSET(JSObject, m_externalStorage)), regT0);
+    Label externalLoad = loadPtrWithPatchToLEA(Address(regT0, FIELD_OFFSET(JSObject, m_externalStorage)), regT0);
     Label externalLoadComplete(this);
     ASSERT(differenceBetween(hotPathBegin, externalLoad) == patchOffsetPutByIdExternalLoad);