Changeset 44693 in webkit for trunk/JavaScriptCore/jit/JIT.h

Timestamp:

Jun 15, 2009, 1:17:50 PM (16 years ago)

Author:

[email protected]

Message:

2009-06-15 Gavin Barraclough <​[email protected]>

Reviewed by Geoff Hunt & Oliver Garen.

We are currently generating two copies of the slow path for op_call for no reason. Stop that.

Originally op_call used two slow paths since the first set up the pointer to the CallLinkInfo
for use when linking. However this is now looked up using the return address (as we do for
property accesses) so the two paths are now identical.

No performance impact, reduces memory footprint.

• bytecode/CodeBlock.h:
• jit/JIT.cpp: (JSC::JIT::privateCompile): (JSC::JIT::linkCall):
• jit/JIT.h:
• jit/JITCall.cpp: (JSC::JIT::compileOpCallSlowCase):
• jit/JITStubs.cpp: (JSC::JITStubs::DEFINE_STUB_FUNCTION):

File:

• trunk/JavaScriptCore/jit/JIT.h (modified) (2 diffs)

trunk/JavaScriptCore/jit/JIT.h

@@ -154 +154 @@
         MacroAssembler::Call hotPathOther;
         MacroAssembler::Call callReturnLocation;
-        MacroAssembler::Label coldPathOther;
     };
 
@@ -386 +385 @@
         }
 
-        static void linkCall(JSFunction* callee, CodeBlock* calleeCodeBlock, JITCode&, CallLinkInfo*, int callerArgCount);
+        static void linkCall(JSFunction* callee, CodeBlock* calleeCodeBlock, JITCode&, CallLinkInfo*, int callerArgCount, JSGlobalData*);
         static void unlinkCall(CallLinkInfo*);