Changeset 46618 in webkit for trunk/JavaScriptCore/bytecode/StructureStubInfo.h

Timestamp:

Jul 30, 2009, 7:20:11 PM (16 years ago)

Author:

[email protected]

Message:

2009-07-23 Gavin Barraclough <​[email protected]>

Reviewed by Oliver Hunt.

Make get_by_id/put_by_id/method_check/call defer optimization using a data flag rather than a code modification.
( ​https://bugs.webkit.org/show_bug.cgi?id=27635 )

This improves performance of ENABLE(ASSEMBLER_WX_EXCLUSIVE) builds by 2-2.5%, reducing the overhead to about 2.5%.
(No performance impact with ASSEMBLER_WX_EXCLUSIVE disabled).

• bytecode/CodeBlock.cpp: (JSC::printStructureStubInfo):
  • Make StructureStubInfo store the type as an integer, rather than an OpcodeID.

• bytecode/CodeBlock.h: (JSC::): (JSC::CallLinkInfo::seenOnce): (JSC::CallLinkInfo::setSeen): (JSC::MethodCallLinkInfo::seenOnce): (JSC::MethodCallLinkInfo::setSeen):
  • Change a pointer in CallLinkInfo/MethodCallLinkInfo to use a PtrAndFlags, use a flag to track when an op has been executed once.

• bytecode/StructureStubInfo.cpp: (JSC::StructureStubInfo::deref):
  • Make StructureStubInfo store the type as an integer, rather than an OpcodeID.

• bytecode/StructureStubInfo.h: (JSC::StructureStubInfo::StructureStubInfo): (JSC::StructureStubInfo::initGetByIdSelf): (JSC::StructureStubInfo::initGetByIdProto): (JSC::StructureStubInfo::initGetByIdChain): (JSC::StructureStubInfo::initGetByIdSelfList): (JSC::StructureStubInfo::initGetByIdProtoList): (JSC::StructureStubInfo::initPutByIdTransition): (JSC::StructureStubInfo::initPutByIdReplace): (JSC::StructureStubInfo::seenOnce): (JSC::StructureStubInfo::setSeen):
  • Make StructureStubInfo store the type as an integer, rather than an OpcodeID, add a flag to track when an op has been executed once.

• bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitGetById): (JSC::BytecodeGenerator::emitPutById):
  • Make StructureStubInfo store the type as an integer, rather than an OpcodeID.

• jit/JIT.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines): (JSC::JIT::unlinkCall):
  • Remove the "don't lazy link" stage of calls.

• jit/JIT.h: (JSC::JIT::compileCTIMachineTrampolines):
  • Remove the "don't lazy link" stage of calls.

• jit/JITCall.cpp: (JSC::JIT::compileOpCallSlowCase):
  • Remove the "don't lazy link" stage of calls.

• jit/JITStubs.cpp: (JSC::JITThunks::JITThunks): (JSC::JITThunks::tryCachePutByID): (JSC::JITThunks::tryCacheGetByID): (JSC::JITStubs::DEFINE_STUB_FUNCTION): (JSC::JITStubs::getPolymorphicAccessStructureListSlot):
  • Remove the "don't lazy link" stage of calls, and the "_second" stage of get_by_id/put_by_id/method_check.

• jit/JITStubs.h: (JSC::JITThunks::ctiStringLengthTrampoline): (JSC::JITStubs::):
  • Remove the "don't lazy link" stage of calls, and the "_second" stage of get_by_id/put_by_id/method_check.

• wtf/PtrAndFlags.h: (WTF::PtrAndFlags::PtrAndFlags): (WTF::PtrAndFlags::operator!): (WTF::PtrAndFlags::operator->):
  • Add ! and -> operators, add constuctor with pointer argument.

File:

• trunk/JavaScriptCore/bytecode/StructureStubInfo.h (modified) (9 diffs)

trunk/JavaScriptCore/bytecode/StructureStubInfo.h

@@ -34 +34 @@
 #include "Structure.h"
 
+
 namespace JSC {
 
+    static const int access_get_by_id_self = 0;
+    static const int access_get_by_id_proto = 1;
+    static const int access_get_by_id_chain = 2;
+    static const int access_get_by_id_self_list = 3;
+    static const int access_get_by_id_proto_list = 4;
+    static const int access_put_by_id_transition = 5;
+    static const int access_put_by_id_replace = 6;
+    static const int access_get_by_id = 7;
+    static const int access_put_by_id = 8;
+    static const int access_get_by_id_generic = 9;
+    static const int access_put_by_id_generic = 10;
+    static const int access_get_array_length = 11;
+    static const int access_get_string_length = 12;
+
     struct StructureStubInfo {
-        StructureStubInfo(OpcodeID opcodeID)
-            : opcodeID(opcodeID)
+        StructureStubInfo(int accessType)
+            : accessType(accessType)
+            , seen(false)
         {
         }
@@ -44 +60 @@
         void initGetByIdSelf(Structure* baseObjectStructure)
         {
-            opcodeID = op_get_by_id_self;
+            accessType = access_get_by_id_self;
 
             u.getByIdSelf.baseObjectStructure = baseObjectStructure;
@@ -52 +68 @@
         void initGetByIdProto(Structure* baseObjectStructure, Structure* prototypeStructure)
         {
-            opcodeID = op_get_by_id_proto;
+            accessType = access_get_by_id_proto;
 
             u.getByIdProto.baseObjectStructure = baseObjectStructure;
@@ -63 +79 @@
         void initGetByIdChain(Structure* baseObjectStructure, StructureChain* chain)
         {
-            opcodeID = op_get_by_id_chain;
+            accessType = access_get_by_id_chain;
 
             u.getByIdChain.baseObjectStructure = baseObjectStructure;
@@ -74 +90 @@
         void initGetByIdSelfList(PolymorphicAccessStructureList* structureList, int listSize)
         {
-            opcodeID = op_get_by_id_self_list;
+            accessType = access_get_by_id_self_list;
 
             u.getByIdProtoList.structureList = structureList;
@@ -82 +98 @@
         void initGetByIdProtoList(PolymorphicAccessStructureList* structureList, int listSize)
         {
-            opcodeID = op_get_by_id_proto_list;
+            accessType = access_get_by_id_proto_list;
 
             u.getByIdProtoList.structureList = structureList;
@@ -92 +108 @@
         void initPutByIdTransition(Structure* previousStructure, Structure* structure, StructureChain* chain)
         {
-            opcodeID = op_put_by_id_transition;
+            accessType = access_put_by_id_transition;
 
             u.putByIdTransition.previousStructure = previousStructure;
@@ -106 +122 @@
         void initPutByIdReplace(Structure* baseObjectStructure)
         {
-            opcodeID = op_put_by_id_replace;
+            accessType = access_put_by_id_replace;
     
             u.putByIdReplace.baseObjectStructure = baseObjectStructure;
@@ -114 +130 @@
         void deref();
 
-        OpcodeID opcodeID;
+        bool seenOnce()
+        {
+            return seen;
+        }
+
+        void setSeen()
+        {
+            seen = true;
+        }
+
+        int accessType : 31;
+        int seen : 1;
+
         union {
             struct {