Changeset 4724 in webkit for trunk/JavaScriptCore/kjs/internal.cpp

Timestamp:

Jul 28, 2003, 5:10:07 PM (22 years ago)

Author:

mjs

Message:

Reviewed by Richard.

• fixed 3240814 - LEAK: 120 byte leak in JavaScript parser in Sherlock Movies channel

• kjs/internal.cpp: (Parser::parse): ref() and deref() the program node, to make sure to clean up properly, before deleting it. (InterpreterImp::checkSyntax): Likewise.

File:

• trunk/JavaScriptCore/kjs/internal.cpp (modified) (2 diffs)

trunk/JavaScriptCore/kjs/internal.cpp

@@ -456 +456 @@
     if (errMsg)
       *errMsg = "Parse error at line " + UString::from(eline);
-    delete prog;
+    if (prog) {
+      // must ref and deref to clean up properly
+      prog->ref();
+      prog->deref();
+      delete prog;
+    }
     return 0;
   }
@@ -726 +731 @@
   ProgramNode *progNode = Parser::parse(code.data(),code.size(),0,0,0);
   bool ok = (progNode != 0);
-  delete progNode;
+  if (progNode) {
+    // must ref and deref to clean up properly
+    progNode->ref();
+    progNode->deref();
+    delete progNode;
+  }
   return ok;
 }