Changeset 47404 in webkit for trunk/JavaScriptCore/runtime/Arguments.h

Timestamp:

Aug 17, 2009, 6:00:12 PM (16 years ago)

Author:

[email protected]

Message:

REGRESSION (r47292): Prototype.js is broken by ES5 Arguments changes
​https://bugs.webkit.org/show_bug.cgi?id=28341
<rdar://problem/7145615>

RS=Mark Rowe

Reverting r47292. Alas Prototype.js breaks with Arguments inheriting
from Array as ES5 attempted. Prototype.js defines $A in terms of a
function it places on (among other global objects) the Array prototype,
thus breaking $A for arrays.

File:

• trunk/JavaScriptCore/runtime/Arguments.h (modified) (4 diffs)

trunk/JavaScriptCore/runtime/Arguments.h

@@ -101 +101 @@
 
         void init(CallFrame*);
-        void initializeStandardProperties(CallFrame*);
 
         OwnPtr<ArgumentsData> d;
@@ -135 +134 @@
         , d(new ArgumentsData)
     {
-        initializeStandardProperties(callFrame);
         JSFunction* callee;
         ptrdiff_t firstParameterIndex;
@@ -174 +172 @@
     {
         ASSERT(!callFrame->callee()->body()->parameterCount());
-        
-        initializeStandardProperties(callFrame);
+
         unsigned numArguments = callFrame->argumentCount() - 1;
 
@@ -243 +240 @@
     }
     
-    
-    inline void Arguments::initializeStandardProperties(CallFrame* callFrame)
-    {
-        putDirectFunction(callFrame->propertyNames().constructor, callFrame->lexicalGlobalObject()->objectConstructor(), DontEnum);
-        putDirectFunction(callFrame->propertyNames().toString, callFrame->lexicalGlobalObject()->objectToStringFunction(), DontEnum);
-        putDirectFunction(callFrame->propertyNames().toLocaleString, callFrame->lexicalGlobalObject()->objectToLocaleStringFunction(), DontEnum);
-    }
 
 } // namespace JSC