Changeset 47519 in webkit for trunk/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp

Timestamp:

Aug 19, 2009, 12:54:55 PM (16 years ago)

Author:

[email protected]

Message:

We probably shouldn't be keeping the AST for eval nodes around forevar.

​https://bugs.webkit.org/show_bug.cgi?id=28469

Reviewed by Darin Adler.

EvalNodes don't destroyData() (delete their parser data) since they need to hold onto
their varStack. Copy a list of variable onto EvalCodeBlock, and this can go away.

• bytecode/CodeBlock.h:

(JSC::EvalCodeBlock::variable):
(JSC::EvalCodeBlock::numVariables):
(JSC::EvalCodeBlock::adoptVariables):

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):

• interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):

• parser/Nodes.h:
• runtime/Executable.cpp:

(JSC::EvalExecutable::generateBytecode):

• runtime/Executable.h:

File:

• trunk/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp (modified) (1 diff)

trunk/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp

@@ -403 +403 @@
         m_codeBlock->addFunctionDecl(adoptRef(new FunctionExecutable(function->ident(), function)));
     }
+
+    const DeclarationStacks::VarStack& varStack = evalNode->varStack();
+    unsigned numVariables = varStack.size();
+    Vector<Identifier> variables;
+    variables.reserveCapacity(numVariables);
+    for (size_t i = 0; i < numVariables; ++i)
+        variables.append(varStack[i].first);
+    codeBlock->adoptVariables(variables);
 
     preserveLastVar();