Changeset 47519 in webkit for trunk/JavaScriptCore/runtime/Executable.h

Timestamp:

Aug 19, 2009, 12:54:55 PM (16 years ago)

Author:

[email protected]

Message:

We probably shouldn't be keeping the AST for eval nodes around forevar.

​https://bugs.webkit.org/show_bug.cgi?id=28469

Reviewed by Darin Adler.

EvalNodes don't destroyData() (delete their parser data) since they need to hold onto
their varStack. Copy a list of variable onto EvalCodeBlock, and this can go away.

• bytecode/CodeBlock.h:

(JSC::EvalCodeBlock::variable):
(JSC::EvalCodeBlock::numVariables):
(JSC::EvalCodeBlock::adoptVariables):

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):

• interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):

• parser/Nodes.h:
• runtime/Executable.cpp:

(JSC::EvalExecutable::generateBytecode):

• runtime/Executable.h:

File:

• trunk/JavaScriptCore/runtime/Executable.h (modified) (2 diffs)

trunk/JavaScriptCore/runtime/Executable.h

@@ -60 +60 @@
         virtual ExceptionInfo* reparseExceptionInfo(JSGlobalData*, ScopeChainNode*, CodeBlock*) = 0;
 
-        ScopeNode* astNode() { return m_node.get(); }
-
     protected:
         RefPtr<ScopeNode> m_node;
@@ -109 +107 @@
             return *m_evalCodeBlock;
         }
-
-        DeclarationStacks::VarStack& varStack() { return m_node->varStack(); }
 
         ExceptionInfo* reparseExceptionInfo(JSGlobalData*, ScopeChainNode*, CodeBlock*);