Changeset 47622 in webkit for trunk/JavaScriptCore/runtime/JSString.h

Timestamp:

Aug 20, 2009, 10:41:54 PM (16 years ago)

Author:

[email protected]

Message:

Added a number => string cache.

Patch by Geoffrey Garen <​[email protected]> on 2009-08-20
Reviewed by Maciej Stachowiak.

1.07x faster on v8 (1.7x faster on v8-splay).
1.004x faster on SunSpider.

• runtime/JSCell.h: Moved JSValue::toString to JSString.h.
• runtime/JSGlobalData.h: Holds the cache.
• runtime/JSNumberCell.cpp:

(JSC::JSNumberCell::toString):
(JSC::JSNumberCell::toThisString): Removed -0 special case.
UString handles this now, since too many clients were
special-casing it.

• runtime/JSString.h:

(JSC::JSValue::toString): Use the cache when converting
an int or double to string.

• runtime/Operations.h:

(JSC::concatenateStrings): Call toString to take advantage
of the cache.

• runtime/SmallStrings.h:

(JSC::NumericStrings::add):
(JSC::NumericStrings::lookup): The cache.

• runtime/UString.cpp:

(JSC::UString::from): Added -0 special case mentioned above.
Removed appendNumeric because it's mutually exclusive with the
cache.

File:

• trunk/JavaScriptCore/runtime/JSString.h (modified) (1 diff)

trunk/JavaScriptCore/runtime/JSString.h

@@ -212 +212 @@
     }
 
+    inline UString JSValue::toString(ExecState* exec) const
+    {
+        if (isString())
+            return static_cast<JSString*>(asCell())->value();
+        if (isInt32())
+            return exec->globalData().numericStrings.add(asInt32());
+        if (isDouble())
+            return exec->globalData().numericStrings.add(asDouble());
+        if (isTrue())
+            return "true";
+        if (isFalse())
+            return "false";
+        if (isNull())
+            return "null";
+        if (isUndefined())
+            return "undefined";
+        ASSERT(isCell());
+        return asCell()->toString(exec);
+    }
+
 } // namespace JSC