Changeset 4783 in webkit for trunk/JavaScriptCore/kjs/string_object.cpp

Timestamp:

Aug 7, 2003, 12:10:01 PM (22 years ago)

Author:

mjs

Message:

Reviewed by Darin.

• fixed 3366975 - repro hang in KJS::Value::Value entering text at eil.com

• kjs/string_object.cpp: (StringProtoFuncImp::call): When doing a match against a regexp with the global flag set, make sure to return null rather than an empty array when there is no match. This is what other browsers do.

File:

• trunk/JavaScriptCore/kjs/string_object.cpp (modified) (1 diff)

trunk/JavaScriptCore/kjs/string_object.cpp

@@ -273 +273 @@
         if (imp)
           imp->put(exec, "lastIndex", Number(lastIndex), DontDelete|DontEnum);
-        result = exec->interpreter()->builtinArray().construct(exec, list);
+        if (list.isEmpty()) {
+          // if there are no matches at all, it's important to return
+          // Null instead of an empty array, because this matches
+          // other browsers and because Null is a false value.
+          result = Null(); 
+        } else {
+          result = exec->interpreter()->builtinArray().construct(exec, list);
+        }
       }
     }