Changeset 47847 in webkit for trunk/JavaScriptCore/runtime/JSONObject.cpp

Timestamp:

Aug 27, 2009, 5:27:10 PM (16 years ago)

Author:

[email protected]

Message:

JSON.stringify replacer array does not accept values that are not string primitives.
​https://bugs.webkit.org/show_bug.cgi?id=28788

Reviewed by Adam Roben

Update the JSON stringifier to initialise its replacer array according to the most
recent version of the spec.

File:

• trunk/JavaScriptCore/runtime/JSONObject.cpp (modified) (1 diff)

trunk/JavaScriptCore/runtime/JSONObject.cpp

@@ -203 +203 @@
             if (exec->hadException())
                 break;
+
+            if (name.isObject()) {
+                if (!asObject(name)->inherits(&NumberObject::info) && !asObject(name)->inherits(&StringObject::info))
+                    continue;
+                name = static_cast<JSWrapperObject*>(asObject(name))->internalValue();
+            }
+
             UString propertyName;
-            if (!name.getString(propertyName))
+            if (name.getString(propertyName)) {
+                m_arrayReplacerPropertyNames.add(Identifier(exec, propertyName));
                 continue;
+            }
+
+            double value = 0;
+            if (name.getNumber(value)) {
+                m_arrayReplacerPropertyNames.add(Identifier::from(exec, value));
+                continue;
+            }
+
             if (exec->hadException())
                 return;
-            m_arrayReplacerPropertyNames.add(Identifier(exec, propertyName));
         }
         return;