Changeset 48573 in webkit for trunk/JavaScriptCore/jit/JITStubs.cpp

Timestamp:

Sep 20, 2009, 10:42:24 PM (16 years ago)

Author:

[email protected]

Message:

SNES is too slow
​https://bugs.webkit.org/show_bug.cgi?id=29534

Reviewed by Maciej Stachowiak.

The problem was that the emulator used multiple classes with
more properties than our dictionary cutoff allowed, this resulted
in more or less all critical logic inside the emulator requiring
uncached property access.

Rather than simply bumping the dictionary cutoff, this patch
recognises that there are two ways to create a "dictionary"
structure. Either by adding a large number of properties, or
by removing a property. In the case of adding properties we
know all the existing properties will maintain their existing
offsets, so we could cache access to those properties, if we
know they won't be removed.

To make this possible, this patch adds the logic required to
distinguish a dictionary created by addition from one created
by removal. With this logic in place we can now cache access
to objects with large numbers of properties.

SNES performance improved by more than 6x.

File:

• trunk/JavaScriptCore/jit/JITStubs.cpp (modified) (6 diffs)

trunk/JavaScriptCore/jit/JITStubs.cpp

@@ -680 +680 @@
     Structure* structure = baseCell->structure();
 
-    if (structure->isDictionary()) {
+    if (structure->isUncacheableDictionary()) {
         ctiPatchCallByReturnAddress(codeBlock, returnAddress, FunctionPtr(cti_op_put_by_id_generic));
         return;
@@ -744 +744 @@
     Structure* structure = baseCell->structure();
 
-    if (structure->isDictionary()) {
+    if (structure->isUncacheableDictionary()) {
         ctiPatchCallByReturnAddress(codeBlock, returnAddress, FunctionPtr(cti_op_get_by_id_generic));
         return;
@@ -1155 +1155 @@
     if (baseValue.isCell()
         && slot.isCacheable()
-        && !(structure = asCell(baseValue)->structure())->isDictionary()
+        && !(structure = asCell(baseValue)->structure())->isUncacheableDictionary()
         && (slotBaseObject = asObject(slot.slotBase()))->getPropertySpecificValue(callFrame, ident, specific)
         && specific
@@ -1229 +1229 @@
     if (baseValue.isCell()
         && slot.isCacheable()
-        && !asCell(baseValue)->structure()->isDictionary()
+        && !asCell(baseValue)->structure()->isUncacheableDictionary()
         && slot.slotBase() == baseValue) {
 
@@ -1300 +1300 @@
     CHECK_FOR_EXCEPTION();
 
-    if (!baseValue.isCell() || !slot.isCacheable() || asCell(baseValue)->structure()->isDictionary()) {
+    if (!baseValue.isCell() || !slot.isCacheable() || asCell(baseValue)->structure()->isUncacheableDictionary()) {
         ctiPatchCallByReturnAddress(callFrame->codeBlock(), STUB_RETURN_ADDRESS, FunctionPtr(cti_op_get_by_id_proto_fail));
         return JSValue::encode(result);
@@ -2189 +2189 @@
     if (globalObject->getPropertySlot(callFrame, ident, slot)) {
         JSValue result = slot.getValue(callFrame, ident);
-        if (slot.isCacheable() && !globalObject->structure()->isDictionary() && slot.slotBase() == globalObject) {
+        if (slot.isCacheable() && !globalObject->structure()->isUncacheableDictionary() && slot.slotBase() == globalObject) {
             GlobalResolveInfo& globalResolveInfo = callFrame->codeBlock()->globalResolveInfo(globalResolveInfoIndex);
             if (globalResolveInfo.structure)