Ignore:
Timestamp:
Sep 29, 2009, 10:54:39 AM (16 years ago)
Author:
[email protected]
Message:

Removed virtual destructor from JSGlobalObjectData to eliminate pointer
fix-ups when accessing JSGlobalObject::d.

Patch by Geoffrey Garen <[email protected]> on 2009-09-28
Reviewed by Sam Weinig.

JavaScriptCore:

Replaced with an explicit destructor function pointer.

6% speedup on bench-alloc-nonretained.js.

(JSC::JSGlobalObject::~JSGlobalObject):
(JSC::JSGlobalObject::destroyJSGlobalObjectData):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData):
(JSC::JSGlobalObject::JSGlobalObject):

JavaScriptGlue:

Replaced with an explicit destructor function pointer.

  • JSRun.cpp:

(JSGlueGlobalObject::destroyData):

  • JSRun.h:

(JSGlueGlobalObject::Data::Data):

WebCore:

Replaced with an explicit destructor function pointer.

  • bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::destroyJSDOMGlobalObjectData):

  • bindings/js/JSDOMGlobalObject.h:

(WebCore::JSDOMGlobalObject::JSDOMGlobalObjectData::JSDOMGlobalObjectData):

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/JavaScriptCore/JavaScriptCore.exp

    r48860 r48883  
    133133__ZN3JSC14JSGlobalObject12markChildrenERNS_9MarkStackE
    134134__ZN3JSC14JSGlobalObject17putWithAttributesEPNS_9ExecStateERKNS_10IdentifierENS_7JSValueEj
     135__ZN3JSC14JSGlobalObject25destroyJSGlobalObjectDataEPv
    135136__ZN3JSC14JSGlobalObject3putEPNS_9ExecStateERKNS_10IdentifierENS_7JSValueERNS_15PutPropertySlotE 
    136137__ZN3JSC14JSGlobalObject4initEPNS_8JSObjectE
Note: See TracChangeset for help on using the changeset viewer.