Changeset 48895 in webkit for trunk/JavaScriptCore/jit/JITArithmetic.cpp

Timestamp:

Sep 29, 2009, 1:28:00 PM (16 years ago)

Author:

[email protected]

Message:

Standardized an optimization for adding non-numbers.

Patch by Geoffrey Garen <​[email protected]> on 2009-09-29
Reviewed by Sam Weinig.

SunSpider says maybe a tiny speedup.

• jit/JITArithmetic.cpp:

(JSC::JIT::emit_op_add):
(JSC::JIT::emitSlow_op_add):

File:

• trunk/JavaScriptCore/jit/JITArithmetic.cpp (modified) (5 diffs)

trunk/JavaScriptCore/jit/JITArithmetic.cpp

@@ -567 +567 @@
     OperandTypes types = OperandTypes::fromInt(currentInstruction[4].u.operand);
 
+    if (!types.first().mightBeNumber() || !types.second().mightBeNumber()) {
+        JITStubCall stubCall(this, cti_op_add);
+        stubCall.addArgument(op1);
+        stubCall.addArgument(op2);
+        stubCall.call(dst);
+        return;
+    }
+
     JumpList notInt32Op1;
     JumpList notInt32Op2;
@@ -630 +638 @@
     unsigned op2 = currentInstruction[3].u.operand;
     OperandTypes types = OperandTypes::fromInt(currentInstruction[4].u.operand);
+
+    if (!types.first().mightBeNumber() || !types.second().mightBeNumber())
+        return;
 
     unsigned op;
@@ -2027 +2038 @@
     unsigned op1 = currentInstruction[2].u.operand;
     unsigned op2 = currentInstruction[3].u.operand;
+    OperandTypes types = OperandTypes::fromInt(currentInstruction[4].u.operand);
+
+    if (!types.first().mightBeNumber() || !types.second().mightBeNumber())
+        return;
 
     if (isOperandConstantImmediateInt(op1) || isOperandConstantImmediateInt(op2)) {
@@ -2384 +2399 @@
     unsigned op2 = currentInstruction[3].u.operand;
 
+    if (!types.first().mightBeNumber() || !types.second().mightBeNumber()) {
+        JITStubCall stubCall(this, cti_op_add);
+        stubCall.addArgument(op1);
+        stubCall.addArgument(op2);
+        stubCall.call(dst);
+        return;
+    }
+
     if (isOperandConstantImmediateInt(op1)) {
         emitGetVirtualRegister(op2, regT0);
@@ -2414 +2437 @@
     unsigned op1 = currentInstruction[2].u.operand;
     unsigned op2 = currentInstruction[3].u.operand;
+
+    if (!types.first().mightBeNumber() || !types.second().mightBeNumber())
+        return;
 
     if (isOperandConstantImmediateInt(op1)) {