Changeset 49585 in webkit for trunk/JavaScriptCore/wtf/MathExtras.h

Timestamp:

Oct 14, 2009, 2:45:27 PM (16 years ago)

Author:

Darin Adler

Message:

JavaScriptCore: Additions so fix for ​https://bugs.webkit.org/show_bug.cgi?id=18994
can build on Windows.

Patch by Darin Adler <Darin Adler> on 2009-10-14

• wtf/MathExtras.h: Added llround and llroundf for Windows.

WebCore: Stringify CSS units manually (without printf) to make the formatting
locale-insensitive and obey CSS spec with respect to large values.

Patch by Evan Martin <​[email protected]> on 2009-10-14
Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=18994

• css/CSSPrimitiveValue.cpp:

(WebCore::appendCSSDouble):
(WebCore::formatWithUnits):
(WebCore::CSSPrimitiveValue::cssText):

LayoutTests: Float formatting changes affect three tests:

• large-number-round-trip now passes
• opacity-float now passes and has more test cases
• compound-2d-transforms output tweaked slightly

Patch by Evan Martin <​[email protected]> on 2009-10-14
Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=18994

• fast/css/large-number-round-trip-expected.txt:
• fast/css/opacity-float-expected.txt:
• fast/css/opacity-float.html:
• platform/mac/fast/css/opacity-float-expected.txt: Removed.
• transforms/2d/compound-2d-transforms-expected.txt:
• transforms/2d/compound-2d-transforms.html:

File:

• trunk/JavaScriptCore/wtf/MathExtras.h (modified) (1 diff)

trunk/JavaScriptCore/wtf/MathExtras.h

@@ -103 +103 @@
 #if COMPILER(MSVC) || COMPILER(RVCT)
 
+inline long long llround(double num) { return static_cast<long long>(num > 0 ? num + 0.5 : ceil(num - 0.5)); }
+inline long long llroundf(float num) { return static_cast<long long>(num > 0 ? num + 0.5f : ceil(num - 0.5f)); }
 inline long lround(double num) { return static_cast<long>(num > 0 ? num + 0.5 : ceil(num - 0.5)); }
 inline long lroundf(float num) { return static_cast<long>(num > 0 ? num + 0.5f : ceilf(num - 0.5f)); }