Changeset 50704 in webkit for trunk/JavaScriptCore/jit/JITStubs.cpp

Timestamp:

Nov 9, 2009, 6:19:04 PM (16 years ago)

Author:

[email protected]

Message:

Can cache prototype lookups on uncacheable dictionaries.
​https://bugs.webkit.org/show_bug.cgi?id=31198

Reviewed by Gavin Barraclough.

Replace fromDictionaryTransition with flattenDictionaryObject and
flattenDictionaryStructure. This change is necessary as we need to
guarantee that our attempt to convert away from a dictionary structure
will definitely succeed, and in some cases this requires mutating the
object storage itself.

File:

• trunk/JavaScriptCore/jit/JITStubs.cpp (modified) (3 diffs)

trunk/JavaScriptCore/jit/JITStubs.cpp

@@ -772 +772 @@
         // should not be treated as a dictionary.
         if (slotBaseObject->structure()->isDictionary())
-            slotBaseObject->setStructure(Structure::fromDictionaryTransition(slotBaseObject->structure()));
+            slotBaseObject->flattenDictionaryObject();
         
         stubInfo->initGetByIdProto(structure, slotBaseObject->structure());
@@ -1182 +1182 @@
         // should not be treated as a dictionary.
         if (slotBaseObject->structure()->isDictionary())
-            slotBaseObject->setStructure(Structure::fromDictionaryTransition(slotBaseObject->structure()));
+            slotBaseObject->flattenDictionaryObject();
 
         // The result fetched should always be the callee!
@@ -1335 +1335 @@
         // should not be treated as a dictionary.
         if (slotBaseObject->structure()->isDictionary())
-            slotBaseObject->setStructure(Structure::fromDictionaryTransition(slotBaseObject->structure()));
+            slotBaseObject->flattenDictionaryObject();
 
         int listIndex;