Changeset 50709 in webkit for trunk/JavaScriptCore/runtime/DateInstanceCache.h

Timestamp:

Nov 9, 2009, 7:58:29 PM (16 years ago)

Author:

[email protected]

Message:

Fixed an edge case that could cause the engine not to notice a timezone
change.

Reviewed by Oliver Hunt.

No test because this case would require manual intervention to change
the timezone during the test.

SunSpider reports no change.

• runtime/DateInstanceCache.h:

(JSC::DateInstanceCache::DateInstanceCache):
(JSC::DateInstanceCache::reset): Added a helper function for resetting
this cache. Also, shrank the cache, since we'll be resetting it often.

• runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::resetDateCache): Include resetting the DateInstanceCache
in resetting Date data. (Otherwise, a cache hit could bypass a necessary
timezone update check.)

File:

• trunk/JavaScriptCore/runtime/DateInstanceCache.h (modified) (2 diffs)

trunk/JavaScriptCore/runtime/DateInstanceCache.h

@@ -57 +57 @@
         DateInstanceCache()
         {
+            reset();
+        }
+        
+        void reset()
+        {
             for (size_t i = 0; i < cacheSize; ++i)
                 m_cache[i].key = NaN;
@@ -73 +78 @@
 
     private:
-        static const size_t cacheSize = 64;
+        static const size_t cacheSize = 16;
 
         struct CacheEntry {