Changeset 50927 in webkit for trunk/JavaScriptCore/wtf/DateMath.cpp

Timestamp:

Nov 12, 2009, 9:08:00 PM (16 years ago)

Author:

[email protected]

Message:

2009-11-12 Steve VanDeBogart <​[email protected]>

Reviewed by Adam Barth.

Calculate the time offset only if we were able to parse
the date string. This saves an IPC in Chromium for
invalid date strings.
​https://bugs.webkit.org/show_bug.cgi?id=31416

• wtf/DateMath.cpp: (WTF::parseDateFromNullTerminatedCharacters): (JSC::parseDateFromNullTerminatedCharacters):

File:

• trunk/JavaScriptCore/wtf/DateMath.cpp (modified) (2 diffs)

trunk/JavaScriptCore/wtf/DateMath.cpp

@@ -825 +825 @@
     int offset;
     double ms = parseDateFromNullTerminatedCharacters(dateString, haveTZ, offset);
+    if (isnan(ms))
+        return NaN;
+
     // fall back to local timezone
     if (!haveTZ) {
@@ -968 +971 @@
     int offset;
     double ms = WTF::parseDateFromNullTerminatedCharacters(dateString, haveTZ, offset);
+    if (isnan(ms))
+        return NaN;
+
     // fall back to local timezone
     if (!haveTZ) {