Changeset 51068 in webkit for trunk/JavaScriptCore/API/tests/testapi.c

Timestamp:

Nov 17, 2009, 12:41:10 AM (16 years ago)

Author:

[email protected]

Message:

Incorrect use of JavaScriptCore API in DumpRenderTree
​https://bugs.webkit.org/show_bug.cgi?id=31577

Reviewed by Maciej Stachowiak

Return undefined rather than a literal null.

File:

• trunk/JavaScriptCore/API/tests/testapi.c (modified) (5 diffs)

trunk/JavaScriptCore/API/tests/testapi.c

@@ -167 +167 @@
         return JSValueMakeUndefined(context);
     }
+    
+    if (JSStringIsEqualToUTF8CString(propertyName, "hasPropertyLie")) {
+        return 0;
+    }
 
     if (JSStringIsEqualToUTF8CString(propertyName, "throwOnGet")) {
@@ -177 +181 @@
     }
     
-    return NULL;
+    return JSValueMakeNull(context);
 }
 
@@ -300 +304 @@
 
     // string conversion -- forward to default object class
-    return NULL;
+    return JSValueMakeNull(context);
 }
 
@@ -375 +379 @@
         break;
     default:
-        return NULL;
+        return JSValueMakeNull(context);
         break;
     }
@@ -383 +387 @@
     JSObjectRef function = JSValueToObject(context, func, exception);
     if (!function)
-        return NULL;
+        return JSValueMakeNull(context);
     JSValueRef value = JSObjectCallAsFunction(context, function, object, 0, NULL, exception);
     if (!value) {