Changeset 51724 in webkit for trunk/JavaScriptCore/runtime/StringObject.cpp

Timestamp:

Dec 4, 2009, 5:21:45 PM (15 years ago)

Author:

[email protected]

Message:

2009-12-04 Kent Hansen <​[email protected]>

Reviewed by Darin Adler.

JavaScript delete operator should return false for string properties
​https://bugs.webkit.org/show_bug.cgi?id=32012

• runtime/StringObject.cpp: (JSC::StringObject::deleteProperty):

2009-12-04 Kent Hansen <​[email protected]>

Reviewed by Darin Adler.

Add test for JavaScript string property deletion
​https://bugs.webkit.org/show_bug.cgi?id=32012

• fast/js/script-tests/string-property-deletion.js: Added.
• fast/js/string-property-deletion-expected.txt: Added.
• fast/js/string-property-deletion.html: Added.

File:

• trunk/JavaScriptCore/runtime/StringObject.cpp (modified) (1 diff)

trunk/JavaScriptCore/runtime/StringObject.cpp

@@ -80 +80 @@
     if (propertyName == exec->propertyNames().length)
         return false;
+    bool isStrictUInt32;
+    unsigned i = propertyName.toStrictUInt32(&isStrictUInt32);
+    if (isStrictUInt32 && internalValue()->canGetIndex(i))
+        return false;
     return JSObject::deleteProperty(exec, propertyName);
 }