Changeset 51760 in webkit for trunk/JavaScriptCore/runtime/ObjectConstructor.cpp

Timestamp:

Dec 7, 2009, 5:50:57 AM (15 years ago)

Author:

[email protected]

Message:

Object.create fails if properties on the descriptor are getters
​https://bugs.webkit.org/show_bug.cgi?id=32219

Reviewed by Maciej Stachowiak.

Correctly initialise the PropertySlots with the descriptor object.

File:

• trunk/JavaScriptCore/runtime/ObjectConstructor.cpp (modified) (6 diffs)

trunk/JavaScriptCore/runtime/ObjectConstructor.cpp

@@ -149 +149 @@
     JSObject* description = asObject(in);
 
-    PropertySlot enumerableSlot;
+    PropertySlot enumerableSlot(description);
     if (description->getPropertySlot(exec, exec->propertyNames().enumerable, enumerableSlot)) {
         desc.setEnumerable(enumerableSlot.getValue(exec, exec->propertyNames().enumerable).toBoolean(exec));
@@ -156 +156 @@
     }
 
-    PropertySlot configurableSlot;
+    PropertySlot configurableSlot(description);
     if (description->getPropertySlot(exec, exec->propertyNames().configurable, configurableSlot)) {
         desc.setConfigurable(configurableSlot.getValue(exec, exec->propertyNames().configurable).toBoolean(exec));
@@ -164 +164 @@
 
     JSValue value;
-    PropertySlot valueSlot;
+    PropertySlot valueSlot(description);
     if (description->getPropertySlot(exec, exec->propertyNames().value, valueSlot)) {
         desc.setValue(valueSlot.getValue(exec, exec->propertyNames().value));
@@ -171 +171 @@
     }
 
-    PropertySlot writableSlot;
+    PropertySlot writableSlot(description);
     if (description->getPropertySlot(exec, exec->propertyNames().writable, writableSlot)) {
         desc.setWritable(writableSlot.getValue(exec, exec->propertyNames().writable).toBoolean(exec));
@@ -178 +178 @@
     }
 
-    PropertySlot getSlot;
+    PropertySlot getSlot(description);
     if (description->getPropertySlot(exec, exec->propertyNames().get, getSlot)) {
         JSValue get = getSlot.getValue(exec, exec->propertyNames().get);
@@ -194 +194 @@
     }
 
-    PropertySlot setSlot;
+    PropertySlot setSlot(description);
     if (description->getPropertySlot(exec, exec->propertyNames().set, setSlot)) {
         JSValue set = setSlot.getValue(exec, exec->propertyNames().set);