Changeset 51933 in webkit for trunk/JavaScriptCore/runtime/Operations.h

Timestamp:

Dec 9, 2009, 5:44:20 PM (15 years ago)

Author:

[email protected]

Message:

JavaScriptCore: ​https://bugs.webkit.org/show_bug.cgi?id=32228
Make destruction of ropes non-recursive to prevent stack exhaustion.
Also, pass a UString& into initializeFiber rather than a Ustring::Rep*,
since the Rep is not being ref counted this could result in usage of a
Rep with refcount zero (where the Rep comes from a temporary UString
returned from a function).

Reviewed by Oliver Hunt.

• runtime/JSString.cpp:

(JSC::JSString::Rope::destructNonRecursive):
(JSC::JSString::Rope::~Rope):

• runtime/JSString.h:

(JSC::JSString::Rope::initializeFiber):

• runtime/Operations.h:

(JSC::concatenateStrings):

LayoutTests: ​https://bugs.webkit.org/show_bug.cgi?id=32228
Reenabling tests.

Reviewed by Oliver Hunt.

• platform/win/Skipped:

File:

• trunk/JavaScriptCore/runtime/Operations.h (modified) (1 diff)

trunk/JavaScriptCore/runtime/Operations.h

@@ -318 +318 @@
                 rope->initializeFiber(i, asString(v));
             else
-                rope->initializeFiber(i, v.toString(callFrame).rep());
+                rope->initializeFiber(i, v.toString(callFrame));
         }