Changeset 51971 in webkit for trunk/JavaScriptCore/runtime/JSVariableObject.cpp

Timestamp:

Dec 10, 2009, 4:06:15 PM (15 years ago)

Author:

[email protected]

Message:

2009-12-10 Kent Hansen <​[email protected]>

Reviewed by Geoffrey Garen.

Remove JSObject::getPropertyAttributes() and all usage of it.
​https://bugs.webkit.org/show_bug.cgi?id=31933

getOwnPropertyDescriptor() should be used instead.

• JavaScriptCore.exp:
• JavaScriptCore.order:
• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
• debugger/DebuggerActivation.cpp: (JSC::DebuggerActivation::getOwnPropertyDescriptor):
• debugger/DebuggerActivation.h:
• runtime/JSObject.cpp: (JSC::JSObject::propertyIsEnumerable):
• runtime/JSObject.h:
• runtime/JSVariableObject.cpp:
• runtime/JSVariableObject.h:

2009-12-10 Kent Hansen <​[email protected]>

Reviewed by Geoffrey Garen.

Remove getPropertyAttributes() from JavaScript bindings.
​https://bugs.webkit.org/show_bug.cgi?id=31933

The functionality is provided by getOwnPropertyDescriptor().

• WebCore.order:
• bindings/js/JSDOMWindowCustom.cpp:
• bindings/js/JSDOMWindowShell.cpp:
• bindings/js/JSDOMWindowShell.h:
• bindings/scripts/CodeGeneratorJS.pm:
• page/DOMWindow.idl:

File:

• trunk/JavaScriptCore/runtime/JSVariableObject.cpp (modified) (1 diff)

trunk/JavaScriptCore/runtime/JSVariableObject.cpp

@@ -54 +54 @@
 }
 
-bool JSVariableObject::getPropertyAttributes(ExecState* exec, const Identifier& propertyName, unsigned& attributes) const
-{
-    SymbolTableEntry entry = symbolTable().get(propertyName.ustring().rep());
-    if (!entry.isNull()) {
-        attributes = entry.getAttributes() | DontDelete;
-        return true;
-    }
-    return JSObject::getPropertyAttributes(exec, propertyName, attributes);
-}
-
 bool JSVariableObject::isVariableObject() const
 {