Changeset 52346 in webkit for trunk/JavaScriptCore/runtime/JSString.h

Timestamp:

Dec 18, 2009, 2:59:18 PM (15 years ago)

Author:

[email protected]

Message:

Add createNonCopying method to UString to make replace constructor passed bool,
to make behaviour more explicit. Add createFromUTF8 to UString (wrapping method
on UString::Rep), since other cases of transliteration (e.g. from ascii) are
performed in UString constructors. Add/use setHash & size() accessors on Rep,
rather than accessing _hash/len directly.

Reviewed by Sam Weinig.

• API/JSClassRef.cpp:

(OpaqueJSClass::OpaqueJSClass):

• API/OpaqueJSString.cpp:

(OpaqueJSString::ustring):

• JavaScriptCore.exp:
• runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncToString):

• runtime/Identifier.cpp:

(JSC::Identifier::equal):
(JSC::CStringTranslator::translate):
(JSC::UCharBufferTranslator::translate):
(JSC::Identifier::addSlowCase):

• runtime/JSString.cpp:

(JSC::JSString::resolveRope):

• runtime/JSString.h:

(JSC::JSString::Rope::Fiber::refAndGetLength):
(JSC::JSString::Rope::append):

• runtime/StringBuilder.h:

(JSC::StringBuilder::release):

• runtime/StringConstructor.cpp:

(JSC::stringFromCharCodeSlowCase):

• runtime/StringPrototype.cpp:

(JSC::substituteBackreferencesSlow):
(JSC::stringProtoFuncToLowerCase):
(JSC::stringProtoFuncToUpperCase):
(JSC::stringProtoFuncFontsize):
(JSC::stringProtoFuncLink):

• runtime/UString.cpp:

(JSC::UString::UString):
(JSC::UString::createNonCopying):
(JSC::UString::createFromUTF8):

• runtime/UString.h:

(JSC::UString::Rep::setHash):
(JSC::UString::~UString):
(JSC::makeString):

File:

• trunk/JavaScriptCore/runtime/JSString.h (modified) (2 diffs)

trunk/JavaScriptCore/runtime/JSString.h

@@ -97 +97 @@
                     if (isString()) {
                         UString::Rep* rep = string();
-                        return rep->ref()->len;
+                        return rep->ref()->size();
                     } else {
                         Rope* r = rope();
@@ -136 +136 @@
                 UString::Rep* rep = string.rep();
                 m_fibers[index++] = Fiber(rep);
-                m_stringLength += rep->ref()->len;
+                m_stringLength += rep->ref()->size();
             }
             void append(unsigned& index, JSString* jsString)