Changeset 52762 in webkit for trunk/JavaScriptCore/API/JSClassRef.cpp

Timestamp:

Jan 4, 2010, 2:49:27 PM (15 years ago)

Author:

[email protected]

Message:

Rubber stamped by Geoff Garen.

Add an 'isIdentifier' to UStringImpl, use this where appropriate
(where previously 'identifierTable' was being tested).

• API/JSClassRef.cpp:

(OpaqueJSClass::~OpaqueJSClass):
(OpaqueJSClassContextData::OpaqueJSClassContextData):

• runtime/Identifier.cpp:

(JSC::Identifier::addSlowCase):

• runtime/Identifier.h:

(JSC::Identifier::add):

• runtime/PropertyNameArray.cpp:

(JSC::PropertyNameArray::add):

• runtime/UStringImpl.h:

(JSC::UStringImpl::isIdentifier):

File:

• trunk/JavaScriptCore/API/JSClassRef.cpp (modified) (4 diffs)

trunk/JavaScriptCore/API/JSClassRef.cpp

@@ -83 +83 @@
 OpaqueJSClass::~OpaqueJSClass()
 {
-    ASSERT(!m_className.rep()->identifierTable());
+    ASSERT(!m_className.rep()->isIdentifier());
 
     if (m_staticValues) {
         OpaqueJSClassStaticValuesTable::const_iterator end = m_staticValues->end();
         for (OpaqueJSClassStaticValuesTable::const_iterator it = m_staticValues->begin(); it != end; ++it) {
-            ASSERT(!it->first->identifierTable());
+            ASSERT(!it->first->isIdentifier());
             delete it->second;
         }
@@ -97 +97 @@
         OpaqueJSClassStaticFunctionsTable::const_iterator end = m_staticFunctions->end();
         for (OpaqueJSClassStaticFunctionsTable::const_iterator it = m_staticFunctions->begin(); it != end; ++it) {
-            ASSERT(!it->first->identifierTable());
+            ASSERT(!it->first->isIdentifier());
             delete it->second;
         }
@@ -148 +148 @@
         OpaqueJSClassStaticValuesTable::const_iterator end = jsClass->m_staticValues->end();
         for (OpaqueJSClassStaticValuesTable::const_iterator it = jsClass->m_staticValues->begin(); it != end; ++it) {
-            ASSERT(!it->first->identifierTable());
+            ASSERT(!it->first->isIdentifier());
             staticValues->add(UString::Rep::createCopying(it->first->data(), it->first->size()),
                               new StaticValueEntry(it->second->getProperty, it->second->setProperty, it->second->attributes));
@@ -161 +161 @@
         OpaqueJSClassStaticFunctionsTable::const_iterator end = jsClass->m_staticFunctions->end();
         for (OpaqueJSClassStaticFunctionsTable::const_iterator it = jsClass->m_staticFunctions->begin(); it != end; ++it) {
-            ASSERT(!it->first->identifierTable());
+            ASSERT(!it->first->isIdentifier());
             staticFunctions->add(UString::Rep::createCopying(it->first->data(), it->first->size()),
                               new StaticFunctionEntry(it->second->callAsFunction, it->second->attributes));