Changeset 53454 in webkit for trunk/JavaScriptCore/runtime/UString.cpp

Timestamp:

Jan 18, 2010, 9:51:40 PM (15 years ago)

Author:

[email protected]

Message:

​https://bugs.webkit.org/show_bug.cgi?id=33731
Remove UntypedPtrAndBitfield from UStringImpl (akin to PtrAndFlags).

Patch by Gavin Barraclough <​[email protected]> on 2010-01-18
Reviewed by Oliver Hunt.

This break the OS X Leaks tool. Instead, free up some more bits from the refCount.

• runtime/UStringImpl.cpp:

(JSC::UStringImpl::sharedBuffer):
(JSC::UStringImpl::~UStringImpl):

• runtime/UStringImpl.h:

(JSC::UStringImpl::cost):
(JSC::UStringImpl::checkConsistency):
(JSC::UStringImpl::UStringImpl):
(JSC::UStringImpl::bufferOwnerString):
(JSC::UStringImpl::):

• wtf/StringHashFunctions.h:

(WTF::stringHash):

File:

• trunk/JavaScriptCore/runtime/UString.cpp (modified) (2 diffs)

trunk/JavaScriptCore/runtime/UString.cpp

@@ -349 +349 @@
 UString UString::spliceSubstringsWithSeparators(const Range* substringRanges, int rangeCount, const UString* separators, int separatorCount) const
 {
-    m_rep->checkConsistency();
-
     if (rangeCount == 1 && separatorCount == 0) {
         int thisSize = size();
@@ -392 +390 @@
 UString UString::replaceRange(int rangeStart, int rangeLength, const UString& replacement) const
 {
-    m_rep->checkConsistency();
-
     int replacementLength = replacement.size();
     int totalLength = size() - rangeLength + replacementLength;