Changeset 53638 in webkit for trunk/JavaScriptCore/API/JSCallbackObject.h

Timestamp:

Jan 21, 2010, 12:46:03 PM (15 years ago)

Author:

[email protected]

Message:

2010-01-21 Kent Hansen <​[email protected]>

Reviewed by Geoffrey Garen.

Object.getOwnPropertyDescriptor always returns undefined for JS API objects
​https://bugs.webkit.org/show_bug.cgi?id=33946

Ideally the getOwnPropertyDescriptor() reimplementation should return an
access descriptor that wraps the property getter and setter callbacks, but
that approach is much more involved than returning a value descriptor.
Keep it simple for now.

• API/JSCallbackObject.h:
• API/JSCallbackObjectFunctions.h: (JSC::::getOwnPropertyDescriptor):
• API/tests/testapi.js:

File:

• trunk/JavaScriptCore/API/JSCallbackObject.h (modified) (1 diff)

trunk/JavaScriptCore/API/JSCallbackObject.h

@@ -62 +62 @@
     virtual bool getOwnPropertySlot(ExecState*, const Identifier&, PropertySlot&);
     virtual bool getOwnPropertySlot(ExecState*, unsigned, PropertySlot&);
+    virtual bool getOwnPropertyDescriptor(ExecState*, const Identifier&, PropertyDescriptor&);
     
     virtual void put(ExecState*, const Identifier&, JSValue, PutPropertySlot&);