Changeset 53815 in webkit for trunk/JavaScriptCore/wtf/ThreadingPthreads.cpp

Timestamp:

Jan 25, 2010, 3:12:45 PM (15 years ago)

Author:

[email protected]

Message:

Fix Chromium Linux tests: the pthread functions on Linux produce segfault if they receive 0 thread handle.
After r53714, we can have 0 thread handles passed to pthread_join and pthread_detach if corresponding threads
were already terminated and their threadMap entries cleared.
Add a 0 check.

Reviewed by David Levin.

• wtf/ThreadingPthreads.cpp:

(WTF::waitForThreadCompletion):
(WTF::detachThread):

File:

• trunk/JavaScriptCore/wtf/ThreadingPthreads.cpp (modified) (2 diffs)

trunk/JavaScriptCore/wtf/ThreadingPthreads.cpp

@@ -208 +208 @@
 
     pthread_t pthreadHandle = pthreadHandleForIdentifier(threadID);
+    if (!pthreadHandle)
+        return 0;
 
     int joinResult = pthread_join(pthreadHandle, result);
@@ -221 +223 @@
 
     pthread_t pthreadHandle = pthreadHandleForIdentifier(threadID);
+    if (!pthreadHandle)
+        return;
 
     pthread_detach(pthreadHandle);