Changeset 54022 in webkit for trunk/JavaScriptCore/runtime/JSByteArray.cpp

Timestamp:

Jan 28, 2010, 2:51:06 PM (15 years ago)

Author:

[email protected]

Message:

2010-01-28 Oliver Hunt <​[email protected]>

Reviewed by Gavin Barraclough.

Simplify anonymous slot implementation
​https://bugs.webkit.org/show_bug.cgi?id=34282

A class must now specify the number of slots it needs at construction time
rather than later on with a transition. This makes many things simpler,
we no longer need to need an additional transition on object creation to
add the anonymous slots, and we remove the need for a number of transition
type checks.

• API/JSCallbackConstructor.h: (JSC::JSCallbackConstructor::createStructure):
• API/JSCallbackFunction.h: (JSC::JSCallbackFunction::createStructure):
• API/JSCallbackObject.h: (JSC::JSCallbackObject::createStructure):
• JavaScriptCore.exp:
• debugger/DebuggerActivation.h: (JSC::DebuggerActivation::createStructure):
• runtime/Arguments.h: (JSC::Arguments::createStructure):
• runtime/BooleanObject.h: (JSC::BooleanObject::createStructure):
• runtime/DateInstance.h: (JSC::DateInstance::createStructure):
• runtime/DatePrototype.h: (JSC::DatePrototype::createStructure):
• runtime/FunctionPrototype.h: (JSC::FunctionPrototype::createStructure):
• runtime/GetterSetter.h: (JSC::GetterSetter::createStructure):
• runtime/GlobalEvalFunction.h: (JSC::GlobalEvalFunction::createStructure):
• runtime/InternalFunction.h: (JSC::InternalFunction::createStructure):
• runtime/JSAPIValueWrapper.h: (JSC::JSAPIValueWrapper::createStructure):
• runtime/JSActivation.h: (JSC::JSActivation::createStructure):
• runtime/JSArray.h: (JSC::JSArray::createStructure):
• runtime/JSByteArray.cpp: (JSC::JSByteArray::createStructure):
• runtime/JSCell.h: (JSC::JSCell::createDummyStructure):
• runtime/JSFunction.h: (JSC::JSFunction::createStructure):
• runtime/JSGlobalObject.h: (JSC::JSGlobalObject::createStructure):
• runtime/JSNotAnObject.h: (JSC::JSNotAnObject::createStructure):
• runtime/JSONObject.h: (JSC::JSONObject::createStructure):
• runtime/JSObject.h: (JSC::JSObject::createStructure): (JSC::JSObject::putAnonymousValue): (JSC::JSObject::getAnonymousValue):
• runtime/JSPropertyNameIterator.h: (JSC::JSPropertyNameIterator::createStructure):
• runtime/JSStaticScopeObject.h: (JSC::JSStaticScopeObject::createStructure):
• runtime/JSString.h: (JSC::Fiber::createStructure):
• runtime/JSVariableObject.h: (JSC::JSVariableObject::createStructure):
• runtime/JSWrapperObject.h: (JSC::JSWrapperObject::createStructure): (JSC::JSWrapperObject::JSWrapperObject):
• runtime/MathObject.h: (JSC::MathObject::createStructure):
• runtime/NumberConstructor.h: (JSC::NumberConstructor::createStructure):
• runtime/NumberObject.h: (JSC::NumberObject::createStructure):
• runtime/RegExpConstructor.h: (JSC::RegExpConstructor::createStructure):
• runtime/RegExpObject.h: (JSC::RegExpObject::createStructure):
• runtime/StringObject.h: (JSC::StringObject::createStructure):
• runtime/StringObjectThatMasqueradesAsUndefined.h: (JSC::StringObjectThatMasqueradesAsUndefined::createStructure):
• runtime/Structure.cpp: (JSC::Structure::~Structure): (JSC::Structure::materializePropertyMap):
• runtime/Structure.h: (JSC::Structure::create): (JSC::Structure::anonymousSlotCount):
• runtime/StructureTransitionTable.h:

2010-01-28 Oliver Hunt <​[email protected]>

Reviewed by Gavin Barraclough.

Simplify anonymous slot implementation
​https://bugs.webkit.org/show_bug.cgi?id=34282

Update JSGlue Structure usage to pass the anonymous slot count.

• UserObjectImp.h: (UserObjectImp::createStructure):

2010-01-28 Oliver Hunt <​[email protected]>

Reviewed by Gavin Barraclough.

Simplify anonymous slot implementation
​https://bugs.webkit.org/show_bug.cgi?id=34282

Update the WebCore JS DOM bindings to correctly pass and
propagate the anonymous slot count information.

• bindings/js/JSDOMBinding.h: (WebCore::DOMObjectWithGlobalPointer::createStructure): (WebCore::DOMConstructorObject::createStructure):
• bindings/js/JSDOMWindowShell.h: (WebCore::JSDOMWindowShell::createStructure):
• bindings/scripts/CodeGeneratorJS.pm:
• bridge/objc/objc_runtime.h: (JSC::Bindings::ObjcFallbackObjectImp::createStructure):
• bridge/runtime_array.h: (JSC::RuntimeArray::createStructure):
• bridge/runtime_method.h: (JSC::RuntimeMethod::createStructure):
• bridge/runtime_object.h: (JSC::RuntimeObjectImp::createStructure):

File:

• trunk/JavaScriptCore/runtime/JSByteArray.cpp (modified) (1 diff)

trunk/JavaScriptCore/runtime/JSByteArray.cpp

@@ -54 +54 @@
 PassRefPtr<Structure> JSByteArray::createStructure(JSValue prototype)
 {
-    PassRefPtr<Structure> result = Structure::create(prototype, TypeInfo(ObjectType, StructureFlags));
+    PassRefPtr<Structure> result = Structure::create(prototype, TypeInfo(ObjectType, StructureFlags), AnonymousSlotCount);
     return result;
 }