Changeset 54394 in webkit for trunk/JavaScriptCore/runtime/DateConstructor.cpp

Timestamp:

Feb 4, 2010, 6:31:35 PM (15 years ago)

Author:

[email protected]

Message:

Add a JSStringBuilder class (similar-to, and derived-from StringBuilder) to
construct JSStrings, throwing a JS exception should we run out of memory whilst
allocating storage for the string.

Reviewed by Oliver Hunt.

Similarly, add jsMakeNontrivialString methods to use in cases where previously
we were calling makeString & passing the result to jsNontrivialString. Again,
these new methods throw if we hit an out of memory condition.

Move throwOutOfMemoryError into ExceptionHelpers, to make it more widely available.

• JavaScriptCore.xcodeproj/project.pbxproj:
• runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncJoin):

• runtime/DateConstructor.cpp:

(JSC::callDate):

• runtime/DatePrototype.cpp:

(JSC::dateProtoFuncToString):
(JSC::dateProtoFuncToUTCString):
(JSC::dateProtoFuncToGMTString):

• runtime/ErrorPrototype.cpp:

(JSC::errorProtoFuncToString):

• runtime/ExceptionHelpers.cpp:

(JSC::throwOutOfMemoryError):

• runtime/ExceptionHelpers.h:
• runtime/JSStringBuilder.h: Added.

(JSC::JSStringBuilder::releaseJSString):
(JSC::jsMakeNontrivialString):

• runtime/NumberPrototype.cpp:

(JSC::numberProtoFuncToPrecision):

• runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncToString):

• runtime/Operations.cpp:
• runtime/Operations.h:
• runtime/RegExpPrototype.cpp:

(JSC::regExpProtoFuncToString):

• runtime/StringBuilder.h:

(JSC::StringBuilder::append):

• runtime/StringPrototype.cpp:

(JSC::stringProtoFuncBig):
(JSC::stringProtoFuncSmall):
(JSC::stringProtoFuncBlink):
(JSC::stringProtoFuncBold):
(JSC::stringProtoFuncFixed):
(JSC::stringProtoFuncItalics):
(JSC::stringProtoFuncStrike):
(JSC::stringProtoFuncSub):
(JSC::stringProtoFuncSup):
(JSC::stringProtoFuncFontcolor):
(JSC::stringProtoFuncFontsize):
(JSC::stringProtoFuncAnchor):

File:

• trunk/JavaScriptCore/runtime/DateConstructor.cpp (modified) (2 diffs)

trunk/JavaScriptCore/runtime/DateConstructor.cpp

@@ -29 +29 @@
 #include "JSGlobalObject.h"
 #include "JSString.h"
+#include "JSStringBuilder.h"
 #include "ObjectPrototype.h"
 #include "PrototypeFunction.h"
@@ -138 +139 @@
     formatDate(ts, date);
     formatTime(ts, time);
-    return jsNontrivialString(exec, makeString(date, " ", time));
+    return jsMakeNontrivialString(exec, date, " ", time);
 }