Changeset 54510 in webkit for trunk/JavaScriptCore/runtime/Identifier.cpp

Timestamp:

Feb 8, 2010, 2:26:59 PM (15 years ago)

Author:

[email protected]

Message:

Use an empty identifier instead of a null identifier for parse
tokens without an identifier.

Reviewed by Sam Weinig.

This helps encapsulate the null UStringImpl within UString.

• parser/Grammar.y:
• parser/NodeConstructors.h:

(JSC::ContinueNode::ContinueNode):
(JSC::BreakNode::BreakNode):
(JSC::ForInNode::ForInNode):

• runtime/CommonIdentifiers.cpp:

(JSC::CommonIdentifiers::CommonIdentifiers):

• runtime/CommonIdentifiers.h:
• runtime/FunctionPrototype.cpp:

(JSC::FunctionPrototype::FunctionPrototype):

File:

• trunk/JavaScriptCore/runtime/Identifier.cpp (modified) (1 diff)

trunk/JavaScriptCore/runtime/Identifier.cpp

@@ -124 +124 @@
 PassRefPtr<UString::Rep> Identifier::add(JSGlobalData* globalData, const char* c)
 {
-    if (!c) {
-        UString::Rep* rep = UString::null().rep();
-        rep->hash();
-        return rep;
-    }
+    ASSERT(c);
+
     if (!c[0]) {
         UString::Rep::empty().hash();