Changeset 54510 in webkit for trunk/JavaScriptCore/runtime/PropertyNameArray.cpp

Timestamp:

Feb 8, 2010, 2:26:59 PM (15 years ago)

Author:

[email protected]

Message:

Use an empty identifier instead of a null identifier for parse
tokens without an identifier.

Reviewed by Sam Weinig.

This helps encapsulate the null UStringImpl within UString.

• parser/Grammar.y:
• parser/NodeConstructors.h:

(JSC::ContinueNode::ContinueNode):
(JSC::BreakNode::BreakNode):
(JSC::ForInNode::ForInNode):

• runtime/CommonIdentifiers.cpp:

(JSC::CommonIdentifiers::CommonIdentifiers):

• runtime/CommonIdentifiers.h:
• runtime/FunctionPrototype.cpp:

(JSC::FunctionPrototype::FunctionPrototype):

File:

• trunk/JavaScriptCore/runtime/PropertyNameArray.cpp (modified) (1 diff)

trunk/JavaScriptCore/runtime/PropertyNameArray.cpp

@@ -31 +31 @@
 void PropertyNameArray::add(UString::Rep* identifier)
 {
-    ASSERT(identifier == UString::null().rep() || identifier == &UString::Rep::empty() || identifier->isIdentifier());
+    ASSERT(identifier == &UString::Rep::empty() || identifier->isIdentifier());
 
     size_t size = m_data->propertyNameVector().size();