Changeset 54545 in webkit for trunk/JavaScriptCore/runtime/UStringImpl.h

Timestamp:

Feb 9, 2010, 3:55:39 AM (15 years ago)

Author:

[email protected]

Message:

Three small string fixes:
(1) StringBuilder::release should CRASH if the buffer allocation failed.
(2) Remove weird, dead code from JSString::tryGetValue, replace with an ASSERT.
(3) Move UString::createFromUTF8 out to the API, as tryCreateStringFromUTF8.

This is only used from the API, and (now) unlike other UString::create
methods may return UString::null() to indicate failure cases. Better
handle these in the API.

Reviewed by Oliver Hunt.

• API/JSClassRef.cpp:

(tryCreateStringFromUTF8):
(OpaqueJSClass::OpaqueJSClass):
(OpaqueJSClassContextData::OpaqueJSClassContextData):

• runtime/JSString.h:

(JSC::Fiber::tryGetValue):

• runtime/StringBuilder.h:

(JSC::StringBuilder::release):

• runtime/UString.cpp:

(JSC::UString::UString):
(JSC::UString::from):
(JSC::UString::find):

• runtime/UString.h:

File:

• trunk/JavaScriptCore/runtime/UStringImpl.h (modified) (1 diff)

trunk/JavaScriptCore/runtime/UStringImpl.h

@@ -88 +88 @@
     static PassRefPtr<UStringImpl> adopt(Vector<UChar, inlineCapacity>& vector)
     {
+        ASSERT(vector.data());
         if (unsigned length = vector.size())
             return adoptRef(new UStringImpl(vector.releaseBuffer(), length, BufferOwned));