Changeset 54571 in webkit for trunk/JavaScriptCore/runtime/JSStringBuilder.h

Timestamp:

Feb 9, 2010, 3:26:56 PM (15 years ago)

Author:

[email protected]

Message:

Rubber Stamped by Geoff Garen.

Rename StringBuilder::release && JSStringBuilder::releaseJSString
to 'build()'.

JavaScriptCore:

• runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncJoin):

• runtime/Executable.cpp:

(JSC::FunctionExecutable::paramString):

• runtime/FunctionConstructor.cpp:

(JSC::constructFunction):

• runtime/JSGlobalObjectFunctions.cpp:

(JSC::encode):
(JSC::decode):
(JSC::globalFuncEscape):
(JSC::globalFuncUnescape):

• runtime/JSONObject.cpp:

(JSC::Stringifier::stringify):

• runtime/JSStringBuilder.h:

(JSC::JSStringBuilder::build):

• runtime/LiteralParser.cpp:

(JSC::LiteralParser::Lexer::lexString):

• runtime/NumberPrototype.cpp:

(JSC::integerPartNoExp):
(JSC::numberProtoFuncToFixed):

• runtime/StringBuilder.h:

(JSC::StringBuilder::build):

WebCore:

• bindings/js/ScriptString.h:

(WebCore::ScriptString::operator+=):

File:

• trunk/JavaScriptCore/runtime/JSStringBuilder.h (modified) (2 diffs)

trunk/JavaScriptCore/runtime/JSStringBuilder.h

@@ -35 +35 @@
 class JSStringBuilder : public StringBuilder {
 public:
-    JSValue releaseJSString(ExecState* exec)
+    JSValue build(ExecState* exec)
     {
         buffer.shrinkToFit();
@@ -41 +41 @@
             return throwOutOfMemoryError(exec);
         return jsString(exec, UString::adopt(buffer));
+    }
+
+private:
+    // Make attempts to call this compile error - if you only wanted a UString,
+    // Why didn't you just use a StringBuilder?!  (This may change, maybe at some
+    // point in the future we'll need to start building a string not knowing whether
+    // we'll want a UString or a JSValue - but until we have this requirement,
+    // block this).
+    UString build()
+    {
+        ASSERT_NOT_REACHED();
+        return StringBuilder::build();
     }
 };