Changeset 55093 in webkit for trunk/JavaScriptCore/runtime/StringBuilder.h

Timestamp:

Feb 22, 2010, 11:12:01 AM (15 years ago)

Author:

[email protected]

Message:

JSStringBuilder should not CRASH if allocation fails, it should throw a JSException.

Reviewed by Oliver Hunt.

• runtime/JSGlobalObjectFunctions.cpp:
• runtime/JSStringBuilder.h:

(JSC::JSStringBuilder::JSStringBuilder):
(JSC::JSStringBuilder::append):
(JSC::JSStringBuilder::build):

• runtime/StringBuilder.h:

(JSC::StringBuilder::build):

• wtf/Vector.h:

(WTF::VectorBufferBase::tryAllocateBuffer):
(WTF::):
(WTF::VectorBuffer::tryAllocateBuffer):
(WTF::::tryExpandCapacity):
(WTF::::tryReserveCapacity):
(WTF::::tryAppend):

File:

• trunk/JavaScriptCore/runtime/StringBuilder.h (modified) (1 diff)

trunk/JavaScriptCore/runtime/StringBuilder.h

@@ -70 +70 @@
     {
         buffer.shrinkToFit();
-        if (buffer.size() && !buffer.data())
-            CRASH();
+        ASSERT(buffer.data() || !buffer.size());
         return UString::adopt(buffer);
     }