Changeset 55751 in webkit for trunk/JavaScriptCore/runtime/Identifier.cpp

Timestamp:

Mar 9, 2010, 3:32:58 PM (15 years ago)

Author:

[email protected]

Message:

This caused a performance regression, by breaking the code
generator's logic to calculate the skip level for resolving
variables (traced by rdar:7683350) Reverting for now.

Reviewed by NOBODY (reverting r54510).

• parser/Grammar.y:
• parser/NodeConstructors.h:

(JSC::ContinueNode::ContinueNode):
(JSC::BreakNode::BreakNode):
(JSC::ForInNode::ForInNode):

• runtime/CommonIdentifiers.cpp:

(JSC::CommonIdentifiers::CommonIdentifiers):

• runtime/CommonIdentifiers.h:
• runtime/FunctionPrototype.cpp:

(JSC::FunctionPrototype::FunctionPrototype):

• runtime/Identifier.cpp:

(JSC::Identifier::add):

• runtime/PropertyNameArray.cpp:

(JSC::PropertyNameArray::add):

File:

• trunk/JavaScriptCore/runtime/Identifier.cpp (modified) (1 diff)

trunk/JavaScriptCore/runtime/Identifier.cpp

@@ -125 +125 @@
 PassRefPtr<UString::Rep> Identifier::add(JSGlobalData* globalData, const char* c)
 {
-    ASSERT(c);
-
+    if (!c) {
+        UString::Rep* rep = UString::null().rep();
+        rep->hash();
+        return rep;
+    }
     if (!c[0]) {
         UString::Rep::empty().hash();