Changeset 57019 in webkit for trunk/JavaScriptCore/runtime/JSObject.h

Timestamp:

Apr 2, 2010, 1:15:53 PM (15 years ago)

Author:

[email protected]

Message:

Inlined toThisString and toThisJSString to avoid virtual function call overhead
​https://bugs.webkit.org/show_bug.cgi?id=37039

Reviewed by Oliver Hunt.

Maybe a 1% speedup on iBench JS.

• JavaScriptCore.exp: New exports.

• runtime/JSCell.cpp:
• runtime/JSCell.h:
• runtime/JSNumberCell.cpp:
• runtime/JSNumberCell.h:
• runtime/JSString.cpp:
• runtime/JSString.h:
• runtime/JSValue.h:
• runtime/JSZombie.h:

(JSC::JSZombie::toThisObject): Nixed the old virtual-type implementation.

• runtime/JSObject.h:

(JSC::JSValue::toThisString):
(JSC::JSValue::toThisJSString): Added the inlined implementation.

File:

• trunk/JavaScriptCore/runtime/JSObject.h (modified) (2 diffs)

trunk/JavaScriptCore/runtime/JSObject.h

@@ -36 +36 @@
 #include "Structure.h"
 #include "JSGlobalData.h"
+#include "JSString.h"
 #include <wtf/StdLibExtras.h>
 
@@ -710 +711 @@
 }
 
+// --- JSValue inlines ----------------------------
+
+ALWAYS_INLINE UString JSValue::toThisString(ExecState* exec) const
+{
+    return isString() ? static_cast<JSString*>(asCell())->value(exec) : toThisObject(exec)->toString(exec);
+}
+
+inline JSString* JSValue::toThisJSString(ExecState* exec) const
+{
+    return isString() ? static_cast<JSString*>(asCell()) : jsString(exec, toThisObject(exec)->toString(exec));
+}
+
 } // namespace JSC