Changeset 57019 in webkit for trunk/JavaScriptCore/runtime/JSString.cpp

Timestamp:

Apr 2, 2010, 1:15:53 PM (15 years ago)

Author:

[email protected]

Message:

Inlined toThisString and toThisJSString to avoid virtual function call overhead
​https://bugs.webkit.org/show_bug.cgi?id=37039

Reviewed by Oliver Hunt.

Maybe a 1% speedup on iBench JS.

• JavaScriptCore.exp: New exports.

• runtime/JSCell.cpp:
• runtime/JSCell.h:
• runtime/JSNumberCell.cpp:
• runtime/JSNumberCell.h:
• runtime/JSString.cpp:
• runtime/JSString.h:
• runtime/JSValue.h:
• runtime/JSZombie.h:

(JSC::JSZombie::toThisObject): Nixed the old virtual-type implementation.

• runtime/JSObject.h:

(JSC::JSValue::toThisString):
(JSC::JSValue::toThisJSString): Added the inlined implementation.

File:

• trunk/JavaScriptCore/runtime/JSString.cpp (modified) (1 diff)

trunk/JavaScriptCore/runtime/JSString.cpp

@@ -144 +144 @@
 }
 
-UString JSString::toThisString(ExecState* exec) const
-{
-    return value(exec);
-}
-
-JSString* JSString::toThisJSString(ExecState*)
-{
-    return this;
-}
-
 inline StringObject* StringObject::create(ExecState* exec, JSString* string)
 {