Changeset 57055 in webkit for trunk/JavaScriptCore/runtime/JSString.h

Timestamp:

Apr 3, 2010, 11:53:46 PM (15 years ago)

Author:

[email protected]

Message:

​https://bugs.webkit.org/show_bug.cgi?id=37068
Change UString to use a 0 rep for null strings instead of a null object.

Reviewed by Oliver Hunt.

No performance impact.

• JavaScriptCore.exp:
• runtime/InternalFunction.cpp:

(JSC::InternalFunction::InternalFunction):

• runtime/JSString.h:

(JSC::RopeBuilder::JSString):

• runtime/UString.cpp:

(JSC::initializeUString):

• runtime/UString.h:

(JSC::UString::UString):
(JSC::UString::data):
(JSC::UString::size):
(JSC::UString::isNull):
(JSC::UString::isEmpty):
(JSC::UString::cost):

File:

• trunk/JavaScriptCore/runtime/JSString.h (modified) (4 diffs)

trunk/JavaScriptCore/runtime/JSString.h

@@ -117 +117 @@
             , m_fiberCount(0)
         {
+            ASSERT(!m_value.isNull());
             Heap::heap(this)->reportExtraMemoryCost(value.cost());
         }
@@ -127 +128 @@
             , m_fiberCount(0)
         {
+            ASSERT(!m_value.isNull());
         }
         JSString(JSGlobalData* globalData, PassRefPtr<UString::Rep> value, HasOtherOwnerType)
@@ -134 +136 @@
             , m_fiberCount(0)
         {
+            ASSERT(!m_value.isNull());
         }
         JSString(JSGlobalData* globalData, PassRefPtr<Rope> rope)
@@ -203 +206 @@
             , m_fiberCount(0)
         {
+            ASSERT(!m_value.isNull());
             // nasty hack because we can't union non-POD types
             m_other.m_finalizerCallback = finalizer;